Skip to content

i18n(fr): complete the French catalog (429 entries) - #2102

Open
Atalantis wants to merge 3 commits into
storytold:mainfrom
Atalantis:fr-complete-catalog
Open

Atalantis wants to merge 3 commits into
storytold:mainfrom
Atalantis:fr-complete-catalog

Conversation

@Atalantis

Copy link
Copy Markdown

What and why

Adds to crates/ui-egui/src/i18n/fr.tsv the 429 keys that other catalogs translate and the French one lacked (+429 −0); no existing row is changed. Strings that had no French row showed in English.

How it was tested

  • A script checked every new entry: same key as the source, every placeholder kept with the same count, edge spaces kept, trailing … kept, no empty translation.
  • cargo test -p cadcraft-ui-egui --lib i18n passes (12 tests, 1 ignored by design).
  • Not run: cargo xtask ci and the app itself. No string was looked at on screen: a label that is too long for its button is possible.

Where the translations come from

  • Machine-translated from the plain meaning of the English labels, using ordinary French technical drawing vocabulary and the wording already in the French catalog. No human pass yet: the entries have not been proofread line by line by a person. I am a native French speaker and will fix anything you flag.
  • No proprietary product, string table or localisation resource was opened or copied.

Notes for the reviewer

  • Nothing else changes: only the French catalog.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • crates/ui-egui/src/i18n/fr.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ATARYS-LAB

Copy link
Copy Markdown
Contributor

Hi @Atalantis, thanks for filling the French gaps. We were about to send a French terminology pass and would rather build on your PR than conflict with it.

A French-speaking draughtsman went through the catalog and chose the words drafters use day to day. A few existing rows read oddly or have the wrong meaning, and some of your new rows reuse them:

English Now Proposed
Ray Rayon (reads as radius) Demi-droite
Construction Line Ligne de construction Droite
Contents (text) Sommaire Contenu
Override (dimensions) Outrepasser / Substitution Remplacer / Remplacement
Fillet Congé Raccord
Blend Raccord lissé Courbe de raccord
Offset (command) Décalage Décaler
Rotate Pivoter Rotation
Break Rupture Coupure
Join Rejoindre Joindre
Boundary Frontière Contour
Wipeout Masquage Masque
Polar Tracking Recherche polaire Repérage polaire
Object Snap Tracking Suivi de l'accrochage aux objets Repérage d'accrochage aux objets
Multileader Repère multiple Ligne de repère multiple
Ordinate (dimension) Ordonnée (Y only) Superposée
Continue (dimension) Continuer Continue
Dimension Space Espace entre cotations Espacer les cotes
Change to Current Layer Déplacer vers le calque courant Transférer sur le calque courant

Nouns that aren't the command keep their word (e.g. Plot offset stays Décalage du tracé).

Two ways, whichever you prefer:

  1. You apply these in i18n(fr): complete the French catalog (429 entries) #2102, existing rows and new ones together.
  2. i18n(fr): complete the French catalog (429 entries) #2102 lands as it is, and we open a follow-up PR on top of it ("depends on i18n(fr): complete the French catalog (429 entries) #2102") that changes the terms everywhere they appear.

Happy to discuss any of these words.

@ATARYS-LAB ATARYS-LAB left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Atalantis, this fills almost every French gap (296 of the 298 strings that show in English on main today), and most rows read well.

We're a French building company and went through all 429 rows with a draughtsman. The suggestions below (one click each to apply) bring the new rows in line with the terms drafters use: mostly those of my earlier comment (repérage, ligne de repère multiple, contour, coupure), plus Attacher and a few new ones (jogged, bind, Xref, drafting aids).

Two strings were added on main after your branch: Details → Détails, Insertion point → Point d'insertion.

The older rows from my first comment (Ray, Fillet, Offset, Rotate…) aren't in this PR's diff. If you'd rather keep #2102 to the new rows, we'll send those as a follow-up PR on top of it.

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Annotative Object Scale Échelle d'objet annotatif
Annotative Update Mise à jour des annotatifs
Apply Appliquer
Attach DWG... Joindre un DWG...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attach is Attacher everywhere in French (the PDF underlay work in #2128 uses it too), with Superposer as its pair for Overlay.

Suggested change
Attach DWG... Joindre un DWG...
Attach DWG... Attacher un DWG...

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Named Views... Vues nommées...
New from Template... Nouveau à partir d'un modèle...
Next Change Modification suivante
No external references are attached. Aucune référence externe n'est jointe.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attach is Attacher everywhere in French (the PDF underlay work in #2128 uses it too), with Superposer as its pair for Overlay.

Suggested change
No external references are attached. Aucune référence externe n'est jointe.
No external references are attached. Aucune référence externe n'est attachée.

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Options Options
Options... Options...
Over-constrained Surcontraint
Overlay Superposition

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attach is Attacher everywhere in French (the PDF underlay work in #2128 uses it too), with Superposer as its pair for Overlay.

Suggested change
Overlay Superposition
Overlay Superposer

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Not Found Introuvable
Not loaded Non chargé
Numbered list Liste numérotée
Object Snap Tracking Settings Paramètres du suivi de l'accrochage aux objets

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking is repérage in French CAD (as in repérage polaire), not suivi or recherche.

Suggested change
Object Snap Tracking Settings Paramètres du suivi de l'accrochage aux objets
Object Snap Tracking Settings Paramètres du repérage d'accrochage aux objets

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Show in Tool Sets Afficher dans les jeux d'outils
Snap Overrides Remplacements d'accrochage
Snap type Type d'accrochage
Snap, grid, polar tracking and Dynamic Input: Accrochage, grille, recherche polaire et saisie dynamique :

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking is repérage in French CAD (as in repérage polaire), not suivi or recherche.

Suggested change
Snap, grid, polar tracking and Dynamic Input: Accrochage, grille, recherche polaire et saisie dynamique :
Snap, grid, polar tracking and Dynamic Input: Accrochage, grille, repérage polaire et saisie dynamique :

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Attach DWG... Joindre un DWG...
Automatic save every Enregistrement automatique toutes les
Automatic save file location Emplacement des fichiers d'enregistrement automatique
Bind Intégrer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binding an xref is lier in French drafting usage.

Suggested change
Bind Intégrer
Bind Lier

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Automatic save every Enregistrement automatique toutes les
Automatic save file location Emplacement des fichiers d'enregistrement automatique
Bind Intégrer
Bind... Intégrer...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binding an xref is lier in French drafting usage.

Suggested change
Bind... Intégrer...
Bind... Lier...

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Only in this drawing: {n} Uniquement dans ce dessin : {n}
Only in {name}: {n} Uniquement dans {name} : {n}
Open Ouvrir
Open Xref Ouvrir la xref

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drafters write Xréf.

Suggested change
Open Xref Ouvrir la xref
Open Xref Ouvrir la Xréf

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
When a command is active Quand une commande est active
When no command is active Quand aucune commande n'est active
Window selection color: Couleur de la sélection par fenêtre :
Xrefs Xrefs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drafters write Xréf.

Suggested change
Xrefs Xrefs
Xrefs Xréfs

Comment thread crates/ui-egui/src/i18n/fr.tsv Outdated
Bring Above Objects Placer au-dessus des objets
Bring Annotations to Front Mettre les annotations au premier plan
Bulleted list Liste à puces
CADCraft keeps these preferences, object snap modes and drafting toggles for your user account and restores them when it starts. CADCraft conserve ces préférences, les modes d'accrochage aux objets et les bascules de dessin pour votre compte utilisateur, et les restaure à son démarrage.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drafting toggles (snap, grid, ortho, polar…) are aides au dessin in French; bascules isn't used for them.

Suggested change
CADCraft keeps these preferences, object snap modes and drafting toggles for your user account and restores them when it starts. CADCraft conserve ces préférences, les modes d'accrochage aux objets et les bascules de dessin pour votre compte utilisateur, et les restaure à son démarrage.
CADCraft keeps these preferences, object snap modes and drafting toggles for your user account and restores them when it starts. CADCraft conserve ces préférences, les modes d'accrochage aux objets et les aides au dessin pour votre compte utilisateur, et les restaure à son démarrage.

@YannFR81

Copy link
Copy Markdown

Thanks for completing the catalog! A few terminology suggestions from a French road designer who uses AutoCAD daily (AI-assisted review):

  • Tracking → « repérage »: Object Snap Tracking Settings → « Paramètres du repérage par accrochage aux objets », and in Snap, grid, polar tracking and Dynamic Input: → « … repérage polaire … » (rather than « suivi » / « recherche polaire »).
  • Dimension Break → « Coupure de cote » (rather than « Rupture de cotation »).
  • Dimension Edit → « Modifier la cote » (rather than « Modification de cotation »): « cote » for the object, « Cotation » for the menu.

The older rows already on main are harmonised in the follow-up #2235 (imperative prompts, cote / espace objet / réseau / présentation / repérage); it doesn't touch the rows added here, so either PR can merge first.

@Atalantis

Copy link
Copy Markdown
Author

Thanks to both of you for the review. Applied in the new commits (the second one merges current main, no conflict left):

  • all 26 one-click suggestions from ATARYS-LAB: repérage for tracking, ligne de repère multiple, contour for hatch boundaries, Attacher / Superposer, Lier for Bind, Découper for Clip, Coupure de cotation, Rayon raccourci / Linéaire raccourcie for the jogged dimensions, Xréf, Rotation in Move/Copy/Rotate;
  • Dimension Edit → Modifier la cote (from YannFR81);
  • four rows that were missing after main moved: Details, Insertion point, Export Comparison and Save changes to block "{name}"?.

Object Snap Tracking Settings uses ATARYS-LAB's wording (Paramètres du repérage d'accrochage aux objets) rather than the other suggestion; they only differ by one word, easy to swap.

The older rows (Ray, Fillet, Offset, Rotate…) are not in this diff: yes please, send them as a follow-up on top of this PR, and #2235 can go in either order. cargo test -p cadcraft-ui-egui --lib i18n passes (14 tests).

@ATARYS-LAB

Copy link
Copy Markdown
Contributor

Thanks @Atalantis, I checked the new commits: all 26 suggestions are in, word for word. The follow-up for the older rows is #2580, on top of this PR: Ray, Xline, Fillet, Blend, Offset, Rotate, Break, Join, Boundary, Wipeout, the tracking modes, Multileader, Ordinate, Override, Dimension Space, Change to Current Layer, Attach and Contents.

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the head of the diff: the French catalogue completed with 429 entries in crates/ui-egui/src/i18n/fr.tsv, appended after "Could not check for updates." as tab-separated English and French pairs ("3D Mouse" / "Souris 3D", "3D mouse busy, possibly 3DxWare or missing device permissions" / "Souris 3D occupee..." and so on). The entries I saw are well formed, keep the ellipsis and the placeholder-free text exactly, and use the French apostrophe and accents correctly ("L'echelle actuelle", "Ajouter un sommet"). I am not a reviewer of French usage beyond that: a native speaker should read the 429 lines, and the CAD terms should follow AutoCAD's French vocabulary (for example "Echelle", "Cotation", "Hachures") so users of the French AutoCAD find what they know. Checks I would run in CI and could not here: the key set matches the English strings the UI uses (a missing key falls back to English), no key is duplicated, tabs and %/{} placeholders match in both columns, and no entry is empty. A translation-only change is low risk. I have not run it, and no exact-head CI result exists for this head, so this is a source-read comment and not an approval. Nothing was run.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

@austin62jake austin62jake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the mechanics. I can't judge the French wording itself, so a fluent reader is still worth having.

I merged this onto current main together with the other open catalog PRs (#2581, #2564, #2296, #2102, #2580). They merge cleanly with each other.

  • cargo xtask i18n passes, and the cadcraft-ui-egui i18n tests (catalog validity, placeholders and ellipses kept, plural forms) pass.
  • Strings in fr that fall back to English: 306 on main, 7 (with #2580 too) with these merged.

This merges cleanly with #2563 (which renames 14 prompt keys in every catalog). Your follow-up #2580 does conflict with it, so whichever of those two lands second needs main merged in.

@ATARYS-LAB

Copy link
Copy Markdown
Contributor

Hi @Atalantis, a heads-up: since 0.19.0 this PR conflicts with main. The conflict is only at the end of crates/ui-egui/src/i18n/fr.tsv, where main added rows (Find and Replace, Keyboard Shortcuts) after the ones this PR adds. Keeping both sides resolves it, with no duplicate keys. I did the same in #2580, which sits on top of this PR. Happy to help if useful.

YannFR81 added a commit to YannFR81/cadcraft that referenced this pull request Nov 11, 2026
Follow-up to the French catalog: harmonises rows already on main, without
touching the rows added by storytold#2102.

- Command-line prompts use the imperative (Sélectionnez, Spécifiez, Entrez),
  as the other prompts already did; menu and button labels keep the infinitive.
- A dimension object and its style are "cote" / "style de cote"; "Cotation"
  stays for the Dimension menu and Quick Dimension.
- Model space is "espace objet", Array is "réseau", a layout is a
  "présentation", tracking is "repérage" (object snap and polar).

Rebased on main after storytold#2563: the prompts that lost their trailing "or" keep
the imperative wording on their new keys. The docs/localization-parity.md
row is left to the maintainers, as AGENTS.md asks.

Original wording written from CADCraft's English strings; no proprietary
localization resources were used.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4cGqxCFJD1m28x2aqwf7Q
YannFR81 added a commit to YannFR81/cadcraft that referenced this pull request Nov 11, 2026
Dimension Space, Dimension Style Override and Object Snap Tracking (with its
F11 variant) are also changed by storytold#2580. Use one wording in both pull requests
so they merge in either order:

- Dimension Space: "Espacer les cotes" (menu labels keep the infinitive)
- Dimension Style Override: "Remplacement de style de cote"
- Object Snap Tracking: "Repérage d'accrochage aux objets", as storytold#2102 already
  uses for Object Snap Tracking Settings

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants