Repository navigation
i18n(fr): the drafting terms in the older rows (depends on #2102) - #2580
ATARYS-LAB wants to merge 5 commits into
Conversation
…epère multiple, contour, attacher)
…raccord, décaler, coupure, contour, masque, repérage) The rows that were in the catalog before storytold#2102 now use the words storytold#2102 adopted for its new rows: Ray, Xline, Fillet, Blend, Offset, Rotate, Break, Join, Boundary, Wipeout, the tracking modes, Multileader, Ordinate, Override, Dimension Space, Change to Current Layer, Attach and Contents. Nouns that are not the command keep their word (plot offset, offset distance, the radius of a circle). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XkJ8y83ji68FwkuL22Qf4n
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the first hunk: the French catalogue changes "Attach" from "Joindre" to "Attacher", and the title says the drafting terms in the older rows are corrected (it depends on #2102). For the CAD command ATTACH (attach an external reference), the AutoCAD French name is "Attacher", so the change matches the Autodesk term, while "Joindre" is the verb of JOIN. Correcting terms to the vendor's French is good, and I can't judge the other rows; a French-speaking draughtsperson should review the list. Make sure a changed key does not break a place where the old word is used in a sentence built from parts, and that the change is also applied wherever "Attach" appears in other rows (menu and command line). I did not read all the rows. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
|
Thanks. "Attach" is now "Attacher" in every row that uses it ("Attacher un DWG...", "Aucune référence externe n'est attachée."). "Joindre" stays the translation of JOIN. These strings are whole rows of the catalogue, not built from parts, so no sentence changes elsewhere. |
austin62jake
left a comment
There was a problem hiding this comment.
Approving on the mechanics. I can't judge the French wording itself, so a fluent reader is still worth having.
I merged this onto current main with #2102 under it and the other open catalog PRs (#2581, #2564, #2296). cargo xtask i18n and the cadcraft-ui-egui i18n tests pass. French falls back to English for 306 strings on main, and for 7 with both French PRs merged.
Heads-up on landing: this conflicts with #2563, which renames 14 prompt keys (dropping a trailing "or") in every catalog, fr.tsv included. Whichever lands second needs main merged in, and the renamed keys need their French text carried over.
The xline angle prompt says "or" once since storytold#2563: its row takes the new source text and keeps "droite". The rows main added at the catalog's end are kept.
Dimension Space, Dimension Style Override and Object Snap Tracking (with its F11 variant) are also changed by storytold#2580. Use one wording in both pull requests so they merge in either order: - Dimension Space: "Espacer les cotes" (menu labels keep the infinitive) - Dimension Style Override: "Remplacement de style de cote" - Object Snap Tracking: "Repérage d'accrochage aux objets", as storytold#2102 already uses for Object Snap Tracking Settings
|
Hi @ATARYS-LAB, #2235 and this PR both change seven existing rows of
One shared row still differs, so whichever PR merges second will conflict on it:
#2235 uses "style de cote" for the dimension style everywhere (Dim style, Dimension Style..., Delete/Rename/Set Current Dimension Style), so I'd suggest "Remplacement de style de cote" here too. If you'd rather keep "cotation", tell me and I'll align #2235 instead. Either way the two PRs then merge in any order. |
Depends on #2102 (this branch is on top of it; the diff includes it until it is merged). It's the follow-up agreed with @Atalantis there.
Problem
#2102 brings the French catalog to the drafting terms (repérage, ligne de repère multiple, contour, attacher…) in the rows it adds. The rows that were in the catalog before still use other words for the same commands, so the interface mixes both: Polar Tracking is « Recherche polaire » in the status bar while the tracking settings say « repérage », and Ray reads « Rayon », which means radius.
Change
33 older rows of
fr.tsv:Nouns that aren't the command keep their word: « Décalage du tracé », « distance de décalage », a circle's « rayon », « Rejoindre le Discord d'ArtCraft ».
Overlap with #2235 (@YannFR81)
#2235 changes four of these rows too:
Whichever lands second takes the other's rows, or we settle on one word each; happy to go with what you prefer.
Tests
cargo test -p cadcraft-ui-egui --lib i18n: 14 passed.cargo xtask cipasses locally.Docs rows (#2520): none; the French coverage in localization-parity.md doesn't change, only words.
Not changed
« Continue » stays « Continuer »: the same string is both Arc ▸ Continue and Dimension ▸ Continue, which can't be told apart in the catalog yet. No English string, no other language, no code.