Repository navigation
i18n(ru): 414 rows the Russian catalog was missing - #2296
JaffarSk24 wants to merge 2 commits into
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
b593980 to
061fb26
Compare
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the first rows: the Russian catalogue gains 414 rows it was missing, in alphabetical position (for example "3D Mouse" as "3D-мышь", "3D Mouse Navigation" as "Навигация 3D-мышью", and "3D Mouse..." as "3D-мышь..."). The visible rows follow the existing style (the hyphen after "3D", the instrumental case in "3D-мышью"). I can't judge 414 rows of Russian, so a native speaker should review them, in particular the CAD terms, which have established Russian names in the AutoCAD localisation (видовой экран, полилиния). Check for duplicate keys with existing rows, that placeholders are kept, that the trailing ... of menu entries matches the key, and that no row is empty. I did not read all rows. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
|
Thanks for the read, @FredApps. The checks you list, run on the whole
The rows were written by a native Russian speaker from the English meaning, as the catalog's clean-room header asks, so no product's localisation was used as a source; the CAD vocabulary follows the terms the existing catalog already uses (видовой экран, полилиния and so on). |
austin62jake
left a comment
There was a problem hiding this comment.
Approving on the mechanics. I can't judge the Russian wording itself, so a fluent reader is still worth having.
I merged this onto current main together with the other open catalog PRs (#2581, #2564, #2296, #2102, #2580). They merge cleanly with each other.
cargo xtask i18npasses, and thecadcraft-ui-eguii18n tests (catalog validity, placeholders and ellipses kept, plural forms) pass.- Strings in ru that fall back to English: 305 on
main, 9 with these merged.
Rows the other catalogs already had: 3D mouse navigation, command aliases, the Options dialog (open and save, selection, grips, snap and tracking), drawing units, plotting, external references, the block editor, table and multileader tools, and drawing comparison. Written from the English meaning by a native speaker.
…follows its new English Main reworded the Options hint about right-clicks during a command (it now points to Right-Click Customization), so the row this PR added for the old wording matched nothing. It is replaced by the new wording, and the new dialog's labels get Russian too. ENTER stays as the key name.
061fb26 to
a1fe958
Compare
|
Rebased on current |
Russian lacked 414 rows the other catalogs have: 3D mouse navigation, command aliases, the Options dialog (open and save, selection, grips, snap and tracking), drawing units, plotting, external references, the block editor, table and multileader tools, and drawing comparison. Inserted in the catalog's order, written from the English meaning by a native speaker, using the terms the catalog already uses (ручки, видовой экран, мультивыноска, объектная привязка).
Checked: placeholders, leading and trailing spaces and
...match the English; the craft-i18n catalog checker finds no format errors in the new rows.