Skip to content

i18n(ru): 414 rows the Russian catalog was missing - #2296

Open
JaffarSk24 wants to merge 2 commits into
storytold:mainfrom
JaffarSk24:i18n-ru-catalog-gaps
Open

JaffarSk24 wants to merge 2 commits into
storytold:mainfrom
JaffarSk24:i18n-ru-catalog-gaps

Conversation

@JaffarSk24

Copy link
Copy Markdown

Russian lacked 414 rows the other catalogs have: 3D mouse navigation, command aliases, the Options dialog (open and save, selection, grips, snap and tracking), drawing units, plotting, external references, the block editor, table and multileader tools, and drawing comparison. Inserted in the catalog's order, written from the English meaning by a native speaker, using the terms the catalog already uses (ручки, видовой экран, мультивыноска, объектная привязка).

Checked: placeholders, leading and trailing spaces and ... match the English; the craft-i18n catalog checker finds no format errors in the new rows.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

  • crates/ui-egui/src/i18n/ru.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@JaffarSk24
JaffarSk24 force-pushed the i18n-ru-catalog-gaps branch from b593980 to 061fb26 Compare October 27, 2026 23:47

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the first rows: the Russian catalogue gains 414 rows it was missing, in alphabetical position (for example "3D Mouse" as "3D-мышь", "3D Mouse Navigation" as "Навигация 3D-мышью", and "3D Mouse..." as "3D-мышь..."). The visible rows follow the existing style (the hyphen after "3D", the instrumental case in "3D-мышью"). I can't judge 414 rows of Russian, so a native speaker should review them, in particular the CAD terms, which have established Russian names in the AutoCAD localisation (видовой экран, полилиния). Check for duplicate keys with existing rows, that placeholders are kept, that the trailing ... of menu entries matches the key, and that no row is empty. I did not read all rows. Nothing was run.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

@JaffarSk24

Copy link
Copy Markdown
Author

Thanks for the read, @FredApps. The checks you list, run on the whole ru.tsv at this head:

  • No duplicate keys (1,428 rows), no empty translations, exactly two tabs on every data row, no BOM, a final newline, no invisible characters.
  • Placeholders match the English on every row, and every row whose English ends in ... ends in ... in Russian too.
  • The two @plural rows have Russian's three forms.
  • The cadcraft i18n tests pass (catalog_is_valid_and_preserves_placeholders_and_ellipses, interface_fonts_cover_every_letter_in_each_catalog and the rest of the 13).

The rows were written by a native Russian speaker from the English meaning, as the catalog's clean-room header asks, so no product's localisation was used as a source; the CAD vocabulary follows the terms the existing catalog already uses (видовой экран, полилиния and so on).

@austin62jake austin62jake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the mechanics. I can't judge the Russian wording itself, so a fluent reader is still worth having.

I merged this onto current main together with the other open catalog PRs (#2581, #2564, #2296, #2102, #2580). They merge cleanly with each other.

  • cargo xtask i18n passes, and the cadcraft-ui-egui i18n tests (catalog validity, placeholders and ellipses kept, plural forms) pass.
  • Strings in ru that fall back to English: 305 on main, 9 with these merged.

Rows the other catalogs already had: 3D mouse navigation, command
aliases, the Options dialog (open and save, selection, grips, snap and
tracking), drawing units, plotting, external references, the block
editor, table and multileader tools, and drawing comparison. Written
from the English meaning by a native speaker.
…follows its new English

Main reworded the Options hint about right-clicks during a command (it now points to Right-Click Customization), so the row this PR added for the old wording matched nothing. It is replaced by the new wording, and the new dialog's labels get Russian too. ENTER stays as the key name.
@JaffarSk24
JaffarSk24 force-pushed the i18n-ru-catalog-gaps branch from 061fb26 to a1fe958 Compare November 8, 2026 16:09
@JaffarSk24

JaffarSk24 commented Nov 8, 2026 •

Copy link
Copy Markdown
Author

Rebased on current main (e56cc4b), the conflict in ru.tsv resolved by keeping every row main has and adding this PR's 414 at their places. One of them had gone stale: #2371 (landed in #2874) reworded the Options hint about right-clicks during a command, so a1fe958 replaces that row with the new wording and adds Russian for the new Right-Click Customization dialog (16 rows; ENTER stays as the key name). Each source text was checked against main's code. cargo test -p cadcraft-ui-egui --lib i18n: 19 passed, 1 ignored (the gaps report); cargo fmt --check clean.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants