You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
i18n(fr): consistent French CAD terminology in existing rows - #2235
Follow-up to #2102, as suggested in its review: harmonises the French rows already on main, without touching the rows #2102 adds (the same rules re-apply cleanly on top of it, so either can merge first).
Command-line prompts in the imperative (Sélectionnez / Spécifiez / Entrez), as most prompts already were; menu and button labels keep the infinitive (Sélectionner tout).
« cote » / « style de cote » for a dimension and its style; « Cotation » stays for the Dimension menu and Quick Dimension.
« espace objet » for model space, « réseau » for array, « présentation » for layout, « repérage » for object snap and polar tracking.
Credits the pass in ATTRIBUTION.md and docs/localization-parity.md.
103 rows changed, no keys added or removed. Original wording written from CADCraft's English strings; no proprietary localization resources were used.
AI-assisted, contributed by @YannFR81 (French road designer, AutoCAD user), who will follow up on review comments. Catalog checks (three columns, duplicate keys, placeholders, ellipses, same key set as main) pass; cargo test -p cadcraft-ui-egui i18n was not run locally, so CI is the first run.
crates/ui-egui/src/i18n/fr.tsv is excluded by !**/*.tsv
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The French translation attribution now identifies a terminology reviewer and describes an AI-assisted consistency pass covering imperative prompts and selected terms.
Changes: French translation attribution
Layer / File(s)
Summary
Record the terminology pass ATTRIBUTION.md
The attribution identifies YannFR81’s terminology pass and describes the AI-assisted consistency pass, including its terminology focus.
This change updates attribution text for a French terminology pass and has no runtime impact. No actionable merge-blocking risk was found. CI should still confirm the i18n tests before merge.
Architecture risk: Low · up to c0129
The change affects 2 systems.
Changed systems:ATTRIBUTION.md, docs
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — ATTRIBUTION.md (service) was modified; 1 changed file maps to changed impact.
observed — docs (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in ATTRIBUTION.md: The French translation attribution adds @YannFR81’s terminology pass and describes the pass as AI-assisted, including its terminology focus.
observed — Modified behavior in docs/localization-parity.md: The French row replaces “no native review yet” with a terminology consistency pass by @YannFR81 and identifies the reviewer’s profession and AutoCAD use.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: consistent French CAD terminology in existing translation rows.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between c012926 and c17cbc9.
Files ignored due to path filters: 1
crates/ui-egui/src/i18n/fr.tsv is excluded by !**/*.tsv
Files selected for processing: 1
ATTRIBUTION.md
Files skipped from review as they are similar to previous changes: 1
ATTRIBUTION.md
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
ReviewerA — source-read COMMENT (not an approval)
I read the first hunks of this French translation PR: "Delete Dimension Style" changes from "Supprimer le style de cotation" to "Supprimer le style de cote" and other existing rows are edited for consistent CAD terminology. I can't judge French CAD terminology beyond noting that the change must be applied to every row that uses the term; a term changed in one row and not in the others is the usual error. Please check the full list against AutoCAD's French UI if the project follows it, and have a French-speaking maintainer confirm. Placeholders and accelerators in the rows I saw were unchanged.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
The reason will be displayed to describe this comment to others. Learn more.
Approving, at c012926. I merged it onto current main with #2203 and #2180. cargo xtask ci passes: all 7 steps, 3058 tests.
I checked the merged fr.tsv (with everything that has landed since this PR was opened) for the usual problem with a terminology pass, a term changed in some rows and not others:
Polar tracking: no "Recherche polaire" is left. It's « repérage polaire » throughout, and object snap tracking is « repérage par accrochage aux objets », matching AutoCAD's French UI.
Dimensions: the one remaining lowercase « cotation » is "variable de cotation" (dimension variable), which is the established term. « Cotation » stays for the menu, as described.
Prompts: 235 Select/Specify/Enter prompts use the imperative. The only infinitives left are the menu labels "Sélectionner tout" and "Sélectionner les objets", which is the rule the PR states.
Model space: no "espace modèle" remains.
I'm not a native French speaker, so this checks consistency, not register.
One small thing: the docs/localization-parity.md hunk falls under AGENTS.md's rule that PRs leave the parity docs to the maintainers and name the row instead. Dropping it would avoid a conflict with their batch updates. The ATTRIBUTION.md credit is fine.
Follow-up to the French catalog: harmonises rows already on main, without
touching the rows added by storytold#2102.
- Command-line prompts use the imperative (Sélectionnez, Spécifiez, Entrez),
as the other prompts already did; menu and button labels keep the infinitive.
- A dimension object and its style are "cote" / "style de cote"; "Cotation"
stays for the Dimension menu and Quick Dimension.
- Model space is "espace objet", Array is "réseau", a layout is a
"présentation", tracking is "repérage" (object snap and polar).
Rebased on main after storytold#2563: the prompts that lost their trailing "or" keep
the imperative wording on their new keys. The docs/localization-parity.md
row is left to the maintainers, as AGENTS.md asks.
Original wording written from CADCraft's English strings; no proprietary
localization resources were used.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C4cGqxCFJD1m28x2aqwf7Q
Dimension Space, Dimension Style Override and Object Snap Tracking (with its
F11 variant) are also changed by storytold#2580. Use one wording in both pull requests
so they merge in either order:
- Dimension Space: "Espacer les cotes" (menu labels keep the infinitive)
- Dimension Style Override: "Remplacement de style de cote"
- Object Snap Tracking: "Repérage d'accrochage aux objets", as storytold#2102 already
uses for Object Snap Tracking Settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2102, as suggested in its review: harmonises the French rows already on
main, without touching the rows #2102 adds (the same rules re-apply cleanly on top of it, so either can merge first).ATTRIBUTION.mdanddocs/localization-parity.md.103 rows changed, no keys added or removed. Original wording written from CADCraft's English strings; no proprietary localization resources were used.
AI-assisted, contributed by @YannFR81 (French road designer, AutoCAD user), who will follow up on review comments. Catalog checks (three columns, duplicate keys, placeholders, ellipses, same key set as
main) pass;cargo test -p cadcraft-ui-egui i18nwas not run locally, so CI is the first run.🤖 Generated with Claude Code
https://claude.ai/code/session_01WFuEoVBig79n6SoCnU1v1S
Summary by CodeRabbit