Skip to content

i18n(ar): translate 129 new strings, use the catalog's terms in 3 - #2564

Merged
echelon merged 1 commit into
storytold:mainfrom
SoldierPePe:i18n/ar-complete
Nov 1, 2026
Merged

echelon merged 1 commit into
storytold:mainfrom
SoldierPePe:i18n/ar-complete

Conversation

@SoldierPePe

Copy link
Copy Markdown
Contributor

Before this change, the Arabic catalog showed 129 interface strings in English. They were added to the UI after the catalog was written: Block Editor and REFEDIT, dynamic blocks, multileader editing, hatch options (islands, origin, boundaries), selection and grip settings, visual effects, command aliases (PGP), backup and units options, and MTEXT ruler and formatting.

This PR adds their translations, so cargo xtask i18n now reports ar: nothing missing.

  • The new rows reuse the catalog's existing terms: كتلة (block), مقبض (grip), تحديد (selection), مرجع خارجي (xref), قالب (template), تهشير (hatch), خط الإشارة المتعدد (multileader), اختصار (alias). Command names, system variables and product names stay as they are (LISP, PGP, PDF, REINIT, QNEWTEMPLATE, Express).
  • Three existing rows now use the catalog's majority term instead of a one-off: Hatch تظليل → تهشير (the catalog's other 12 hatch rows already say تهشير), Leader قائد → خط الإشارة, and Multileader قائد متعدد → خط الإشارة المتعدد (to match Add Leader, Remove Leader and Multileader Style). قائد ("commander") isn't how Arabic drafting refers to a leader line. Screening stays التظليل, which is the correct plot term.
  • Placeholders and trailing ellipses match the source strings, as catalog_is_valid_and_preserves_placeholders_and_ellipses checks.

Checks

  • cargo test -p cadcraft-ui-egui --lib i18n: 14 passed. These tests cover catalog validity, interface font coverage of every letter, dialogs rendering in every language, and the live language switch.
  • cargo xtask i18n: ar: nothing missing.

Affected row: docs/localization-parity.md Arabic (UI strings translated).

The Arabic catalog showed 129 interface strings in English: the Block Editor and REFEDIT, dynamic blocks, multileader editing, hatch islands, origin and boundaries, selection and grip settings, visual effects, command aliases, backup and units options, and the MTEXT ruler. `cargo xtask i18n` now reports `ar: nothing missing`.

Hatch, Leader and Multileader now use the terms the rest of the catalog uses (تهشير, خط الإشارة) instead of تظليل and قائد.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • crates/ui-egui/src/i18n/ar.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the first rows: an Arabic translation PR that translates 129 new strings and uses the catalogue's terms in three rows; one visible change replaces "تظليل" with "تهشير" for Hatch, consistent with the existing rows "تحرير التهشير" and "نمط التهشير", which is the right direction. I can't judge Arabic beyond that; a native speaker should check the 129 rows. Right-to-left rows must keep placeholders and punctuation in their logical places, and there must be no duplicate keys with existing rows. I did not read all rows.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

@SoldierPePe

Copy link
Copy Markdown
Contributor Author

Thanks. On the points you raised:

  • Native check: I'm a native Arabic speaker and have read the 129 new rows and the three changed ones.
  • Placeholders and punctuation: every row keeps the source's {placeholders} and trailing ellipsis, which catalog_is_valid_and_preserves_placeholders_and_ellipses checks. Colons, the quoted "{name}" and the {x}, {y} order stay where the English has them. Questions end in Arabic ؟ and lists use the Arabic comma ،.
  • Duplicate keys: there are none. parse reports a duplicate key as an error, and that test requires no errors. I also checked the 129 keys against the existing rows before adding them.

cargo test -p cadcraft-ui-egui --lib i18n: 14 passed. cargo xtask i18n: ar: nothing missing.

@austin62jake austin62jake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the mechanics. I can't judge the Arabic wording itself, so a fluent reader is still worth having.

I merged this onto current main together with the other open catalog PRs (#2581, #2564, #2296, #2102, #2580). They merge cleanly with each other.

  • cargo xtask i18n passes, and the cadcraft-ui-egui i18n tests (catalog validity, placeholders and ellipses kept, plural forms) pass.
  • Strings in ar that fall back to English: 133 on main, 4 with these merged.

@echelon
echelon merged commit e187c5f into storytold:main Nov 1, 2026
1 check passed
@echelon

echelon commented Nov 1, 2026

Copy link
Copy Markdown
Member

Landed — thank you @SoldierPePe for this contribution to CADCraft! If you haven't already, come join us on Discord: https://discord.gg/artcraft

A-Gift-Of-Flame added a commit to A-Gift-Of-Flame/cadcraft that referenced this pull request Nov 2, 2026
Resolve the ar.tsv conflict by keeping both appended blocks (this
branch's update-notice rows and main's new Arabic strings from storytold#2564).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants