Repository navigation
i18n(ar): translate 129 new strings, use the catalog's terms in 3 - #2564
Conversation
The Arabic catalog showed 129 interface strings in English: the Block Editor and REFEDIT, dynamic blocks, multileader editing, hatch islands, origin and boundaries, selection and grip settings, visual effects, command aliases, backup and units options, and the MTEXT ruler. `cargo xtask i18n` now reports `ar: nothing missing`. Hatch, Leader and Multileader now use the terms the rest of the catalog uses (تهشير, خط الإشارة) instead of تظليل and قائد.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the first rows: an Arabic translation PR that translates 129 new strings and uses the catalogue's terms in three rows; one visible change replaces "تظليل" with "تهشير" for Hatch, consistent with the existing rows "تحرير التهشير" and "نمط التهشير", which is the right direction. I can't judge Arabic beyond that; a native speaker should check the 129 rows. Right-to-left rows must keep placeholders and punctuation in their logical places, and there must be no duplicate keys with existing rows. I did not read all rows.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
|
Thanks. On the points you raised:
|
austin62jake
left a comment
There was a problem hiding this comment.
Approving on the mechanics. I can't judge the Arabic wording itself, so a fluent reader is still worth having.
I merged this onto current main together with the other open catalog PRs (#2581, #2564, #2296, #2102, #2580). They merge cleanly with each other.
cargo xtask i18npasses, and thecadcraft-ui-eguii18n tests (catalog validity, placeholders and ellipses kept, plural forms) pass.- Strings in ar that fall back to English: 133 on
main, 4 with these merged.
|
Landed — thank you @SoldierPePe for this contribution to CADCraft! If you haven't already, come join us on Discord: https://discord.gg/artcraft |
Resolve the ar.tsv conflict by keeping both appended blocks (this branch's update-notice rows and main's new Arabic strings from storytold#2564). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Before this change, the Arabic catalog showed 129 interface strings in English. They were added to the UI after the catalog was written: Block Editor and REFEDIT, dynamic blocks, multileader editing, hatch options (islands, origin, boundaries), selection and grip settings, visual effects, command aliases (PGP), backup and units options, and MTEXT ruler and formatting.
This PR adds their translations, so
cargo xtask i18nnow reportsar: nothing missing.catalog_is_valid_and_preserves_placeholders_and_ellipseschecks.Checks
cargo test -p cadcraft-ui-egui --lib i18n: 14 passed. These tests cover catalog validity, interface font coverage of every letter, dialogs rendering in every language, and the live language switch.cargo xtask i18n:ar: nothing missing.Affected row:
docs/localization-parity.mdArabic (UI strings translated).