Skip to content

i18n(pt-BR): translate the rows the sibling catalogs cover - #2581

Merged
tanish2k09 merged 2 commits into
storytold:mainfrom
RicSchonfelder:i18n/pt-br-extra-rows
Nov 2, 2026
Merged

tanish2k09 merged 2 commits into
storytold:mainfrom
RicSchonfelder:i18n/pt-br-extra-rows

Conversation

@RicSchonfelder

@RicSchonfelder RicSchonfelder commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

The Brazilian Portuguese catalog covers the reference catalog and every marked UI literal, but 191 strings and the four menu headings (Cota, Desenho, Modificar, Exibir) that the German, French, Swedish and Ukrainian catalogs already translate still fell back to English: the Hatch and Gradient dialog, the Block Editor and dynamic-block grips, the plot and drawing-units dialogs, multileader editing, the selection-preview settings and the unit names.

This PR translates them with the catalog's vocabulary (dimension = cota, hatch = hachura, grip = pinça, layout = apresentação, multileader = multilinha, xref = referência externa), keeps the prompt keywords, SPDX tokens and technology names in English, and appends the rows after the existing entries. Placeholders, ellipses and colons are unchanged; docs/localization.md and docs/localization-parity.md record the new count (1,447 rows).

Clean-room, AI-assisted, as with the earlier pt-BR work; native proofreading is welcome.

No Rust code changed.

Summary by CodeRabbit

  • Documentation
    • Updated localization coverage information for Brazilian Portuguese, reflecting 1,447 catalog entries, up from 1,231.
    • Documented newly included translations and four menu headings across affected interface areas.
    • Added a review-history entry noting 191 added entries and confirming that placeholders, ellipses, and prompt keywords remain unchanged.

The Brazilian Portuguese catalog covered the reference catalog and every marked UI literal, but 191
strings that the German, French, Swedish and Ukrainian catalogs already translate still fell back to
English: the Hatch and Gradient dialog, the Block Editor and dynamic-block grips, the plot and drawing
units dialogs, multileader editing, selection preview settings and the unit names.

Rows follow the catalog's vocabulary (dimension = cota, hatch = hachura, grip = pinça, layout =
apresentação, multileader = multilinha, xref = referência externa), keep the prompt keywords, SPDX
tokens and technology names in English, and are appended after the existing entries.
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between b6331c8 and 2e1accb.

Files ignored due to path filters: 1
  • crates/ui-egui/src/i18n/pt_br.tsv is excluded by !**/*.tsv
Files selected for processing: 2
  • docs/localization-parity.md
  • docs/localization.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The localization pages now report 1,447 Brazilian Portuguese catalog rows and describe coverage of strings translated in sibling catalogs. The parity page records the latest update and summarizes the added rows and menu headings.

Changes: Localization documentation

Layer / File(s) Summary
Catalog coverage and revision record
docs/localization.md, docs/localization-parity.md
The pages report 1,447 Brazilian Portuguese catalog rows and expanded coverage. The parity page updates its review date and records 191 added rows, four menu headings, and unchanged placeholders, ellipses, and prompt keywords.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: aiongg, ffishman, dylanmtaylor

Merge Risk: Minimal · previous review 2e1ac

This documentation-only change accurately records the Brazilian Portuguese catalog expansion and introduces no runtime or deployment risk.

Architecture risk: Low · up to 2e1ac

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/localization-parity.md: The metadata’s last-updated date advances from 2026-10-30 to 2026-10-31, and its latest change description now reports the Brazilian Portuguese additions.
  • observed — Modified behavior in docs/localization-parity.md: The Brazilian Portuguese catalog count rises from 1,231 to 1,447 rows; the row now describes coverage of strings translated in sibling catalogs, while retaining the other catalog, review, and completion details.
  • observed — Modified behavior in docs/localization-parity.md: Adds a revision-history entry describing 191 Brazilian Portuguese rows and four menu headings for previously untranslated strings across the listed UI areas; it states placeholders, ellipses, and prompt keywords were unchanged.
  • observed — Modified behavior in docs/localization.md: The Portuguese catalog count changes from 1,231 to 1,447 rows. Its stated coverage expands from the reference catalog and marked UI literals to also include strings translated by sibling catalogs.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: adding Brazilian Portuguese translations for rows covered by sibling catalogs.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@RicSchonfelder

Copy link
Copy Markdown
Contributor Author

The revision-history row and the two counts (docs/localization.md, docs/localization-parity.md) already cover this change, so no further doc edit was needed. CI: the i18n tests are the ones that matter here (parse, duplicates, placeholders, ellipses); no Rust code changed.

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the first rows: a Brazilian Portuguese translation adds about 200 rows that the sibling catalogues cover and pt-BR didn't ("translated 2026-10-31"), under a comment line, for example "Add: Pick points" as "Adicionar: indicar pontos" and "Alias" as "Alias". I can't judge the Portuguese beyond a plausible spot check; a native speaker should review the 200 rows. Check there are no duplicate keys with existing rows, placeholders and accelerators are preserved, and the comment line in a TSV is accepted by the loader (other catalogues use # lines, which I assume are ignored). I did not read all rows.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

@austin62jake austin62jake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the mechanics. I can't judge the Portuguese (Brazil) wording itself, so a fluent reader is still worth having.

I merged this onto current main together with the other open catalog PRs (#2581, #2564, #2296, #2102, #2580). They merge cleanly with each other.

  • cargo xtask i18n passes, and the cadcraft-ui-egui i18n tests (catalog validity, placeholders and ellipses kept, plural forms) pass.
  • Strings in pt-BR that fall back to English: 121 on main, 2 with these merged.

Please also drop the docs/localization-parity.md hunk. AGENTS.md now says PRs name the rows and maintainers update the parity docs in batches. docs/localization.md is a guide, so that change can stay.

@RicSchonfelder

Copy link
Copy Markdown
Contributor Author

Done in f5436c9. I dropped the docs/localization-parity.md hunk as requested; docs/localization.md stays in the PR. Thanks for the mechanical review and the local i18n test run.

@tanish2k09
tanish2k09 merged commit 6660d88 into storytold:main Nov 2, 2026
6 checks passed
A-Gift-Of-Flame added a commit to A-Gift-Of-Flame/cadcraft that referenced this pull request Nov 2, 2026
Conflicts, keeping both sides:
- exchange.rs: EXPORT keeps this branch's 3D-camera PNG path; main's
  report_loss now writes the not-saved and SAT-text notes (storytold#2334).
- lib.rs: Session keeps last_point3 and main's AREA/PERIMETER/DISTANCE
  variables (storytold#2552).
- pt_br.tsv: keep both appended blocks (storytold#2581).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants