Repository navigation
feat(whatsapp-store): store whatsmeow state encrypted in Postgres - #8537
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Title check | |
The title "feat(whatsapp-store): store whatsmeow state encrypted in Postgres" uses a conventional commits prefix and is 65 characters, under the 72-character limit. It matches the main change: the new… |
| Description check | |
The description explains the why (linked-device Signal sessions and app state are sensitive and must move with the lease), the what (the whatsapp_store_pg crate, AES-256-GCM sealing with KMS-wrapped p… |
Full details: Title check
-
Explanation
The title "feat(whatsapp-store): store whatsmeow state encrypted in Postgres" uses a conventional commits prefix and is 65 characters, under the 72-character limit. It matches the main change: the new crates/whatsapp_store_pg crate persists whatsmeow store state in Postgres, encrypted per account and fenced by lease epoch.
Full details: Description check
-
Explanation
The description explains the why (linked-device Signal sessions and app state are sensitive and must move with the lease), the what (the whatsapp_store_pg crate, AES-256-GCM sealing with KMS-wrapped per-account keys, lease_epoch write checks, the fake-kms feature, and the store migration), and the stack of dependent PRs. It is directly related to the changeset.
✨ Finishing Touches: 💡 1
-
⚔️ Resolve merge conflicts: 💡
-
- Resolve merge conflict in branch
wolf/wa-5-store
- Resolve merge conflict in branch
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
e55c04d to
ae0171a
Compare
ae0171a to
5cd737d
Compare
5cd737d to
97e8516
Compare
0a5d1c5 to
6e490b4
Compare
a90d731 to
a376e99
Compare
a376e99 to
e26bb36
Compare
3465e7e to
d935a2a
Compare
0c9895a to
dc3858e
Compare
d935a2a to
2e278e1
Compare
404Wolf
changed the title
2e278e1 to
e027528
Compare
dc3858e to
5096d8c
Compare
Why: A linked device's Signal sessions, identity keys, pre-keys and app state are as sensitive as the account itself, and whichever session-service replica holds an account's lease must be able to pick it up after another releases it. They belong in Postgres, encrypted per account and fenced by the lease. What: - `crates/whatsapp_store_pg`: implements every `whatsmeow::store` trait for one account. Each value is sealed with AES-256-GCM under a per-account data key wrapped by KMS (associated data = account | store | key); every write checks the account's `lease_epoch`. The threat model is the crate doc comment in `src/lib.rs`. A fake KMS (`fake-kms` feature) backs tests. - Migration `20261027062649_whatsapp_store`: device, store values, pre-keys, app-state MACs, privacy tokens, event buffer and outgoing events, all cascading from `whatsapp_linked_account` (layer 4). - SQLx cache entries; regenerated `workspace-hack` and closures.
5096d8c to
fc93036
Compare
Why
A linked device's Signal sessions, identity keys, pre-keys and app state
are as sensitive as the account itself, and whichever session-service
replica holds an account's lease must be able to pick it up after another
releases it. They belong in Postgres, encrypted per account and fenced
by the lease.
What
crates/whatsapp_store_pg: implements everywhatsmeow::storetrait forone account. Each value is sealed with AES-256-GCM under a per-account
data key wrapped by KMS (associated data = account | store | key); every
write checks the account's
lease_epoch. The threat model is the cratedoc comment in
src/lib.rs. A fake KMS (fake-kmsfeature) backs tests.20261027062649_whatsapp_store: device, store values,pre-keys, app-state MACs, privacy tokens, event buffer and outgoing
events, all cascading from
whatsapp_linked_account(layer 4).workspace-hackand closures.Stack
WhatsApp linked devices, one layer per PR. Merge bottom-up; each PR is based on the one below it, so its diff is only its own layer. Layers 1-9 are
wolf/whatsmeow-rsas of the split; layers 10-16 are the later work on that branch, regrouped by topic. The audit fixes are folded into the layers that own the code they fix. The schema is three migrations in its final shape: layer 4's20261027061310_whatsapp_linkedand20261027061311_validate_entity_whatsapp_group_type, and layer 5's20261027062649_whatsapp_store; no later layer adds a migration.Previous: #8536 · Next: #8538