Skip to content

starboard: Remove dead Evergreen Lite guards - #12486

Open
hferreiro wants to merge 2 commits into
youtube:mainfrom
hferreiro:evergreen-lite-cleanup
Open

starboard: Remove dead Evergreen Lite guards#12486
hferreiro wants to merge 2 commits into
youtube:mainfrom
hferreiro:evergreen-lite-cleanup

Conversation

@hferreiro

@hferreiro hferreiro commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

SB_IS(EVERGREEN_COMPATIBLE_LITE) has not been defined since the sb_evergreen_compatible_enable_lite GN arg was removed in 10b7c61. Evergreen Lite is selected at runtime with the --evergreen_lite loader flag.

Bug: 272635054

SB_IS(EVERGREEN_COMPATIBLE_LITE) has not been defined since the
sb_evergreen_compatible_enable_lite GN arg was removed in
youtube@10b7c61.
Evergreen Lite is selected at runtime with the --evergreen_lite loader
flag.

Bug: 272635054
@hferreiro
hferreiro requested a review from a team as a code owner September 7, 2026 13:45
@hferreiro
hferreiro requested a review from johnxwork September 7, 2026 13:45
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
Context State Description
CI / android ❌ FAIL Failed
CI / aosp ✅ PASS Passed
CI / evergreen ❌ FAIL Failed
CI / linux ❌ FAIL Failed
CI / tvos ✅ PASS Passed
import/copybara ✅ PASS Change imported to Gerrit
kokoro ✅ PASS Kokoro build finished

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


starboard: Remove dead Evergreen Lite guards

The SB_IS(EVERGREEN_COMPATIBLE_LITE) macro is no longer defined since
the sb_evergreen_compatible_enable_lite GN argument was removed in a
previous commit. Evergreen Lite is now selected at runtime using the
--evergreen_lite loader flag, making these compile-time guards
obsolete.

This update cleans up the codebase by removing unused preprocessor
logic and updating the documentation to reflect the current
configuration process.

Bug: 272635054

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the Evergreen configuration by removing the EVERGREEN_COMPATIBLE_LITE preprocessor guards and configuration options across documentation and source files, making the pending restart functionality standard. The review feedback suggests improving the grammatical phrasing in the updated documentation files for better readability.

Comment thread cobalt/site/docs/gen/starboard/doc/evergreen/cobalt_evergreen_lite.md Outdated
Comment thread starboard/doc/evergreen/cobalt_evergreen_lite.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants