starboard: Remove dead Evergreen Lite guards - #12486
Open
hferreiro wants to merge 2 commits into
Open
Conversation
SB_IS(EVERGREEN_COMPATIBLE_LITE) has not been defined since the sb_evergreen_compatible_enable_lite GN arg was removed in youtube@10b7c61. Evergreen Lite is selected at runtime with the --evergreen_lite loader flag. Bug: 272635054
Contributor
|
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the Evergreen configuration by removing the EVERGREEN_COMPATIBLE_LITE preprocessor guards and configuration options across documentation and source files, making the pending restart functionality standard. The review feedback suggests improving the grammatical phrasing in the updated documentation files for better readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SB_IS(EVERGREEN_COMPATIBLE_LITE)has not been defined since thesb_evergreen_compatible_enable_liteGN arg was removed in 10b7c61. Evergreen Lite is selected at runtime with the --evergreen_lite loader flag.Bug: 272635054