Skip to content

docs: Replace obsolete GYP references with GN in docker_build and cobalt_evergreen_lite - #12437

Open
andrewsavage1 wants to merge 1 commit into
youtube:mainfrom
andrewsavage1:update-gyp-doc-references
Open

docs: Replace obsolete GYP references with GN in docker_build and cobalt_evergreen_lite#12437
andrewsavage1 wants to merge 1 commit into
youtube:mainfrom
andrewsavage1:update-gyp-doc-references

Conversation

@andrewsavage1

@andrewsavage1 andrewsavage1 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Update documentation in docker_build.md and cobalt_evergreen_lite.md (and their corresponding site/docs/gen/ copies) to refer to GN instead of GYP for platform and configuration arguments.

Fixed: 482404018

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation across several files to reference the GN build system instead of GYP. The reviewer pointed out that since the build system is being updated to GN, the boolean configuration values in the documentation should also be updated from 1 to true to reflect GN conventions rather than GYP conventions.


`kSbSystemPathStorageDirectory` is not required to implement. Set both
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gyp`
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In GN, boolean arguments are set to true or false rather than 1 or 0 (which was the GYP convention). Since the documentation is being updated to refer to GN, we should also update the values to true.

Suggested change
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn`
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `true` in the `gn`


`kSbSystemPathStorageDirectory` is not required to implement. Set both
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gyp`
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In GN, boolean arguments are set to true or false rather than 1 or 0 (which was the GYP convention). Since the documentation is being updated to refer to GN, we should also update the values to true.

Suggested change
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn`
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `true` in the `gn`

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


docs: Replace obsolete GYP references with GN

Update documentation in docker_build.md and cobalt_evergreen_lite.md,
along with their corresponding generated copies, to refer to GN
instead of GYP for platform and configuration arguments. GYP is
obsolete in the Cobalt build system.

Bug: None

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

…alt_evergreen_lite

Update documentation in docker_build.md and cobalt_evergreen_lite.md (and their
corresponding site/docs/gen/ copies) to refer to GN instead of GYP for platform
and configuration arguments.

TAG=agy
CONV=5f5c2b0b-3d36-4502-b6cb-14d35b81cdcd

`kSbSystemPathStorageDirectory` is not required to implement. Set both
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gyp`
`sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sb_evergreen_compatible has been replaced by is_starboard

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsavage1 I just removed this references at #12486.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants