docs: Replace obsolete GYP references with GN in docker_build and cobalt_evergreen_lite - #12437
docs: Replace obsolete GYP references with GN in docker_build and cobalt_evergreen_lite#12437andrewsavage1 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the documentation across several files to reference the GN build system instead of GYP. The reviewer pointed out that since the build system is being updated to GN, the boolean configuration values in the documentation should also be updated from 1 to true to reflect GN conventions rather than GYP conventions.
|
|
||
| `kSbSystemPathStorageDirectory` is not required to implement. Set both | ||
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gyp` | ||
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn` |
There was a problem hiding this comment.
In GN, boolean arguments are set to true or false rather than 1 or 0 (which was the GYP convention). Since the documentation is being updated to refer to GN, we should also update the values to true.
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn` | |
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `true` in the `gn` |
|
|
||
| `kSbSystemPathStorageDirectory` is not required to implement. Set both | ||
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gyp` | ||
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn` |
There was a problem hiding this comment.
In GN, boolean arguments are set to true or false rather than 1 or 0 (which was the GYP convention). Since the documentation is being updated to refer to GN, we should also update the values to true.
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn` | |
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `true` in the `gn` |
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
…alt_evergreen_lite Update documentation in docker_build.md and cobalt_evergreen_lite.md (and their corresponding site/docs/gen/ copies) to refer to GN instead of GYP for platform and configuration arguments. TAG=agy CONV=5f5c2b0b-3d36-4502-b6cb-14d35b81cdcd
7ca0902 to
12046e5
Compare
|
|
||
| `kSbSystemPathStorageDirectory` is not required to implement. Set both | ||
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gyp` | ||
| `sb_evergreen_compatible` and `sb_evergreen_compatible_lite` to `1`s in the `gn` |
There was a problem hiding this comment.
sb_evergreen_compatible has been replaced by is_starboard
There was a problem hiding this comment.
@andrewsavage1 I just removed this references at #12486.
Update documentation in docker_build.md and cobalt_evergreen_lite.md (and their corresponding site/docs/gen/ copies) to refer to GN instead of GYP for platform and configuration arguments.
Fixed: 482404018