Improve Go commentary with grounded move evidence and concise explanations - #61
Open
DavidDing16 wants to merge 1 commit into
Open
DavidDing16 wants to merge 1 commit into
DavidDing16 wants to merge 1 commit into
Conversation
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current-move commentary can confuse a geometric relationship with tactical intent, focus on individual stones while missing group development or whole-board priorities, and produce long explanations. This change supplies verifiable before-move evidence and asks the teacher to select one supported purpose for a concise explanation.
Verification
pnpm test(392 tests passed).pnpm typecheck.pnpm build.python -m unittest discover -s scripts/tests(11 tests).Notes
For the best teaching results, we recommend a multimodal model that accepts images. This recommendation is documented in both Chinese and English READMEs. The current workflow validates board images alongside exact SGF coordinates and KataGo evidence. Structured board evidence itself does not require vision, but a validated text-only workflow and controlled image/no-image comparison are not part of this PR.
Intent candidates remain hypotheses. Ko counterfactuals validate board structure, not historical superko legality. A complete pipeline or passing tests do not establish semantic accuracy; reviewed positions used for fixes are development regressions. Some generated explanations still include unnecessary secondary observations.
The exploratory linear/CNN/probe routes are documented; no trained weights were integrated. Private SGFs, source comments, expert feedback files, local credentials, model binaries, generated reports and machine-specific evaluation artifacts are excluded. Selected local board/game/KataGo/knowledge evidence continues to be sent to the user-configured LLM, not web search. Packaging/release artifacts have not been validated or published.