Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current v0.4.21 Windows NVIDIA bundle contains KataGo 1.17.1 but omits its directly imported
nvrtc64_120_0.dll. The official portable archive (SHA-2567b52ab7e87e3356c22f28ec028bb7c91f2e825f9e78ddcb894f0d313ab2ac8a8) returns loader status0xC0000135forkatago.exe version. Adding the official CUDA 12.1 NVRTC pair makes that same binary exit 0; withdrawing it reproduces the failure. The official NSIS payload also fails the new dependency check for the same missing DLL.Fixes #58.
Verification
75c96473e7f3be817eb129433221268c4479dac2: CI run 37115875671 passed all five jobs, including NVIDIA clean startup and Windows/macOS/Linux package checks; P0 RC run 37115875660 passed both jobs.Notes
The NVRTC LICENSE is byte-identical to the CUDA Runtime license already shipped; its Attachment A lists NVRTC and builtins as distributable components under the existing distribution terms. No new license acceptance, global CUDA installation, system PATH/driver/security change, existing installation replacement, GPU analysis, merge or release was performed.
Local artifacts are isolated test builds, not published installations. The local portable archive uses compression level 1 to limit CPU time; release compression remains level 7. This validation concerns packaged KataGo loader/startup behavior, not complete application or GPU QA. See docs/WINDOWS_NVIDIA_RUNTIME.md for official sources, hashes, checks and limits.
Based on main
6debe9e431a6761c003f05c975c0a9b8d37f8fbc. PR #61's commentary changes are not included.