Repository navigation
[CI][Do not merge] Staging: automatic sharding on by default - #66965
Thangnguyenvn98 wants to merge 2 commits into
Conversation
e36e664 to
7d428ed
Compare
|
Staging evidence for ci-infra#884, without merging it:
These experiments cover two selected engine steps and their mirrors, not every command shape. Deferred jobs run whole and unsharded. They used an earlier staged isolated-inventory path; the rebased #884 head is undergoing final review and a final control build. No universal rollout-safety claim is being made. |
646d60e to
5f269df
Compare
Turns on automatic_shard_default in ci_config.yaml and deletes every automatic_shard: true, to stage ci-infra#885 in a scoped build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
A step that opts out, a mirror that opts out alone, a mirror that opts in while its step opts out, and pytest-shard flags in a job's PYTEST_ADDOPTS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
5f269df to
3c86ffe
Compare
|
Build 102735 failed in bootstrap before any test shard started. The checkout and ci-infra revision were correct, but the installed generator omitted |
|
Final validation for ci-infra#884 at Control 102749 versus same-code main-generator baseline 102756:
Earlier planted-gap build 102532 deliberately removed four IDs from shard records: every shard passed and all 797 tests actually ran, but the hard coverage job failed the build and named all four IDs. Earlier packaging failure 102735 was corrected and covered by an installed-package CI check before the final control. This is selected evidence, not universal rollout proof. Live cancellation, soft-fail, retried-shard, transport-failure and long-queue/deadline cases remain unexercised. Test IDs must be deterministic. Inventory collection has a 300-second bound; longer collection fails coverage rather than passing unchecked. A descendant that starts its own session can outlive the process group, so external resource cleanup is not guaranteed in that case. Both PRs remain unmerged. |
|
Staging is complete. Final coverage evidence is recorded in #66965 (comment) and the ci-infra#884 description. This throwaway PR was never intended for merge. |
Overview
Throwaway staging PR for vllm-project/ci-infra#885 (automatic sharding on by default). Do not merge; it is closed once the scoped build is read.
Claims
automatic_shard_default: trueinci_config.yamland everyautomatic_shard: truedeleted, pipeline generation succeeds.parallelismruns as it does today; a job that can't be sharded runs as one job and is listed in one warning annotation.Validation
A scoped build with
VLLM_CI_BRANCH=agent/shard-default-onon six keys:engine-1-gpu+ its AMD mirror,language-models-tests-hybrid+ its AMD mirror,distributed-torchrun-shutdown-tests-2-gpus,docker-build-metadata. Results follow as a comment.Details
The change here is only the config line and the deleted flags. The generator change is in ci-infra#885.
Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code