Repository navigation
[CI] Turn automatic sharding on by default - #64796
Open
Thangnguyenvn98 wants to merge 1 commit into
Open
Thangnguyenvn98 wants to merge 1 commit into
Thangnguyenvn98 wants to merge 1 commit into
Conversation
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Thangnguyenvn98
force-pushed
the
agent/shard-default-on
branch
from
November 13, 2026 20:23
ba321b6 to
b757975
Compare
Thangnguyenvn98
marked this pull request as ready for review
November 13, 2026 21:58
Thangnguyenvn98
force-pushed
the
agent/shard-default-on
branch
from
November 13, 2026 22:00
b757975 to
48b9cbd
Compare
Set `automatic_shard_default: true` in the CI config, so the pipeline generator plans shards for every step whose test commands are plain pytest, without a per-step `automatic_shard: true`. A step opts out with `automatic_shard: false`; a step that can't be split keeps running as one job. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Thang Nguyen <thangnguyenvn647@gmail.com>
Thangnguyenvn98
force-pushed
the
agent/shard-default-on
branch
from
November 14, 2026 01:40
48b9cbd to
7430061
Compare
Contributor
Author
Build note: #102675 (scoped, head
|
| Job | Shards | Slowest shard | Node IDs vs main | Machine time vs main |
|---|---|---|---|---|
| CPU V1 Others | 2 | 15.5 min (main: one job, 27 to 31 min) | 2978 = 2978; 0 missing, 0 added, 0 outcome changed, 0 duplicates | +4% |
| CPU Reasoning + Renderers | 2 | 10.0 min (main: one job, 19 to 21 min) | 1267 = 1267; 0 missing, 0 added, 0 outcome changed | -1% |
Main's single-job times are from its five newest runs of each, so the baseline is typical.
Things a reviewer may stop on:
- Reasoning + Renderers shows one "duplicate" node ID in the comparison. It is one parametrized test whose ID contains a multi-line template, so two of its cases print the same first line in the log. Main shows the same thing.
- Reasoning + Renderers' test total sits right at one shard's budget, so its plan can switch between one and two shards from build to build as timings move. Both are covered: one shard is how it runs today, and this build shows two.
- CPU Multimodal + Config, the third CPU step the switch changes in PR builds, was checked the same way on [CI] Enroll 3 CPU steps in automatic sharding #67534 (scoped build #102575: 947 node IDs equal to main, +6%).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Trunk change: needs line-by-line review (one line in
.buildkite/ci_config.yamlthat changes how every step's shards are decided).Sets
automatic_shard_default: true, so the pipeline generator plans shards for every step whose test commands are plain pytest, without a per-stepautomatic_shard: true. The generator support is vllm-project/ci-infra#885. A step opts out withautomatic_shard: false. A step that can't be split (a script,cargo, a fixed hand split) keeps running exactly as it does today.Main carries 464
automatic_shard: trueflags today, so for almost every step this changes nothing. After it merges, a new step shards without anyone adding the flag.This replaces the earlier content of this PR, which predated the generator rework and marked exclusions step by step; those are no longer needed.
Claims
Validation
Details
automatic_shard: falseis added. Whether any of the six steps should be held back is a per-step call. If their enrollment PRs merge first, this PR changes no step at all.Pull Request Checklist
I used vLLM's
/pr-checklistskill. (Mandatory for agents, optional for humans).AI assistance was used during the creation of this PR.
Design Fit: Minimizes impact on core components, reuses existing functionality, and justifies added complexity.
Testing and Validation: Validates the change and ensures any added tests are meaningful and reliable, with CI coverage or documented CI resource constraints and validation performed outside CI.
Code Quality and Style: Keeps code and comments clear and concise, and updates relevant documentation and examples.
Pull Request Contents: Includes a brief summary and relevant links, supports claims with evidence, explains root causes and implementation trade-offs, and follows the contributing guide.
🤖 Generated with Claude Code
BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)