Forcibly normalize all sequences when reading in a GFA#4961
Open
faithokamoto wants to merge 1 commit into
Open
Forcibly normalize all sequences when reading in a GFA#4961faithokamoto wants to merge 1 commit into
faithokamoto wants to merge 1 commit into
Conversation
Contributor
Author
|
Also resolves #2919 which is a more direct explanation of the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
Resolves #3871 by forcing even
vg convert -g <lowercase.gfa> -vto output with normalized base sequences. (We could also make this warn, e.g. withsanitize_sequence_in_place(), but since it doesn't warn on conversion to PG I kept everything silent.)