Skip to content

Maintain ethers v5 helpers and resolve carried issues - #6

Open
mswilkison wants to merge 4 commits into
releases/v0.6.0from
codex/ethers-v5-deploy-v1
Open

mswilkison wants to merge 4 commits into
releases/v0.6.0from
codex/ethers-v5-deploy-v1

Conversation

@mswilkison

@mswilkison mswilkison commented Sep 10, 2026 •

Copy link
Copy Markdown

Maintains the ethers v5 release line as @threshold-network/hardhat-helpers@0.6.0-pre.22, starting from the fork's existing pre.21 tag. Includes upstream PR #56's hardhat-deploy 1.x peer support without rolling consumers back to pre.15.

The carried issues now have implementations for this release line:

The expanded suite also exposed an old unawaited time-helper assertion; it is now awaited and past-block errors are consistent. Generated fixture artifacts/manifests stay out of git.

Packaging includes compiled output, the new entry points, and migration documentation. CI covers the locked and deploy-v1 stacks, and the manual workflow builds release artifacts without publishing.

Validation:

  • Node 16 / Hardhat 2.10 / ethers 5.6.9 / deploy 0.11.11 / Upgrades 1.22: typecheck, build, 55 tests.
  • Node 24 / Hardhat 2.29 / ethers 5.8 / deploy 1.0.4 / Upgrades 1.28: typecheck, build, 55 tests.
  • Frozen lockfile install, ESLint, Prettier, and npm pack passed.
  • A clean Node 24 consumer installed the actual tarball, loaded named signers/block helpers, and typechecked without installing the optional Upgrades plugin.

The counterpart for ethers v6 is #7. Issues #2–#5 should close after both release-line PRs merge. Issue #1 concerns the v6 transaction adapter, which remains necessary even in current upstream OpenZeppelin code.

MIGRATION.md maps the hard package/import switch onto existing keep-core #4326, tbtc-v2 #1142, and solidity-contracts #193. Those PRs currently change manifest values only; release selection, import changes, and regenerated lockfiles remain consumer work. No package has been published by this PR.

Apply the peer-range change from keep-network/hardhat-helpers#56 on the existing pre.21 baseline. Its verification behavior is already present, and no runtime source is changed. Prepare the Threshold package namespace and test both legacy and deploy-v1 consumers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant