Repository navigation
Maintain ethers v5 helpers and resolve carried issues - #6
Open
mswilkison wants to merge 4 commits into
Open
mswilkison wants to merge 4 commits into
mswilkison wants to merge 4 commits into
Conversation
Apply the peer-range change from keep-network/hardhat-helpers#56 on the existing pre.21 baseline. Its verification behavior is already present, and no runtime source is changed. Prepare the Threshold package namespace and test both legacy and deploy-v1 consumers.
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintains the ethers v5 release line as
@threshold-network/hardhat-helpers@0.6.0-pre.22, starting from the fork's existing pre.21 tag. Includes upstream PR #56's hardhat-deploy 1.x peer support without rolling consumers back to pre.15.The carried issues now have implementations for this release line:
/baseloads and typechecks without the OpenZeppelin Upgrades plugin;/upgradesand the existing root entry enable proxy support. The plugin is an optional peer, and runtime dependencies are explicit.deployProxy(..., { redeploy: true })creates a fresh proxy and replaces the named record only after success. The duplicate guard remains the default.noCompile: true. Tests exercise deployed bytecode and the real task, with the explorer boundary mocked, and verify that contract/library/constructor inputs and artifacts are preserved.The expanded suite also exposed an old unawaited time-helper assertion; it is now awaited and past-block errors are consistent. Generated fixture artifacts/manifests stay out of git.
Packaging includes compiled output, the new entry points, and migration documentation. CI covers the locked and deploy-v1 stacks, and the manual workflow builds release artifacts without publishing.
Validation:
The counterpart for ethers v6 is #7. Issues #2–#5 should close after both release-line PRs merge. Issue #1 concerns the v6 transaction adapter, which remains necessary even in current upstream OpenZeppelin code.
MIGRATION.mdmaps the hard package/import switch onto existing keep-core #4326, tbtc-v2 #1142, and solidity-contracts #193. Those PRs currently change manifest values only; release selection, import changes, and regenerated lockfiles remain consumer work. No package has been published by this PR.