Skip to content

Revalidate verification without recompiling deployment artifacts #5

Open

Description

@mswilkison

Carry forward upstream keep-network/hardhat-helpers#39: keep-network/hardhat-helpers#39

The verification helper still calls verify:verify without an explicit noCompile option. The upstream issue proposed that option to avoid recompilation mismatches: NomicFoundation/hardhat#3173

Before changing the default, reproduce the issue separately with the supported legacy etherscan plugin on the ethers v5 line and hardhat-verify on the ethers v6 line. Confirm the actual task API and how build-info is located in each version.

Acceptance criteria:

  • Verification uses the intended build artifacts without changing their contents.
  • Contract, constructor arguments, and library addresses are preserved.
  • Cover missing build information and already-verified responses.
  • Document whether noCompile is supported directly, requires a different subtask, or is unnecessary on the maintained plugin.

This is a carried backlog item, not a claim that the old workaround is valid for every current plugin version.

Activity

  1. mswilkison commented on Sep 10, 2026

    @mswilkison
    Author

    Implemented in the two maintained release-line PRs: #6 (ethers v5) and #7 (ethers v6).

    Both include optional base/upgrades entry points, explicit fresh proxy deployment with record preservation on failure, real-chain upgrade regression coverage, and verification against existing artifacts. The v5 task now passes noCompile with etherscan 3.1.8+; v6's supported verification task already avoids main compilation. V6 preparation also leaves the canonical record unchanged until execution is confirmed.

    Validation passed on all four supported test stacks: 55 tests per v5 stack and 71 per v6 stack, plus typechecks, builds, lint/format checks, packaging, and clean tarball consumers without the optional OpenZeppelin Upgrades plugin.

    Leaving this issue open for the two PRs to merge; the implementation work is complete. README and MIGRATION.md describe the API and consumer changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions