Skip to content

llext: Allow multiple DP instances of same module #11140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsarha wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

llext: Allow multiple DP instances of same module #11140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/library_manager/llext_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,9 +843,15 @@ static int llext_manager_add_mod_domain(struct lib_manager_module *mctx, struct

/*
* Add to domain on first load: for "normal" modules use_count == 1,
* for dependencies use_count == 2 and n_dependent == 1
* for dependencies use_count == 2 and n_dependent == 1.
* This does not apply to DP modules, since they are, for now,
* all in their own memory domains.
*
* NOTE: This approach will make it impossible to have one module
* to have both LL and DP instances within one configuration.
* This will be fixed in future.
Comment on lines +850 to +852
*/
if (ext->use_count > 1 && mctx->n_dependent != 1)
if (!mctx->domain_dp && ext->use_count > 1 && mctx->n_dependent != 1)
return 0;

int ret = llext_manager_add_partition(domain, va_base_text, text_size,
Expand Down
Loading