llext: Allow multiple DP instances of same module - #11140
Open
jsarha wants to merge 1 commit into
Open
Conversation
The LL userspace changes broke support of multiple instances of same DP module. This is a quick remedy to fix that. The fix has a down side that it does not allow having both LL and DP instances of the same module within a same configuration. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 28, 2026 09:11
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes regression where multiple DP (Data Processing) instances of the same LLEXT module could not be safely used after recent LL userspace changes, by ensuring module segments are added to each DP instance’s memory domain even when the underlying LLEXT is already refcounted.
Changes:
- Treat DP modules as a special case when deciding whether to add module partitions to a memory domain (don’t skip on
use_count > 1). - Document the known limitation that mixed LL+DP instances of the same module in one configuration are not supported by this quick remedy.
Suppressed comments (1)
src/library_manager/llext_manager.c:854
- This change intentionally makes mixed LL+DP instances of the same module unsupported, but the code currently may still proceed in such a configuration and later fault (e.g.,
llext_manager_add_domain()can return success while skipping all partition additions whenmctx->domain_dpis false and the module is already refcounted). Consider failing fast when a new instance’sipc_config->proc_domainconflicts with the already-mapped module’smctx->domain_dp(e.g., inllext_manager_allocate_module()), returning an error and logging a clear message instead of allowing a hard-to-debug crash.
* NOTE: This approach will make it impossible to have one module
* to have both LL and DP instances within one configuration.
* This will be fixed in future.
*/
if (!mctx->domain_dp && ext->use_count > 1 && mctx->n_dependent != 1)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+850
to
+852
| * NOTE: This approach will make it impossible to have one module | ||
| * to have both LL and DP instances within one configuration. | ||
| * This will be fixed in future. |
lyakh
approved these changes
Aug 28, 2026
kv2019i
approved these changes
Aug 28, 2026
lgirdwood
approved these changes
Aug 28, 2026
abonislawski
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LL userspace changes broke support of multiple instances of same DP module. This is a quick remedy to fix that. The fix has a down side that it does not allow having both LL and DP instances of the same module within a same configuration.
This fixes #11133