fix(api): keep queued run comments from expiring plans - #223
Open
shuntianyifang wants to merge 3 commits into
Open
fix(api): keep queued run comments from expiring plans#223shuntianyifang wants to merge 3 commits into
shuntianyifang wants to merge 3 commits into
Conversation
adrian-lorenzo
requested changes
Sep 1, 2026
adrian-lorenzo
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
The acknowledgement regex accepts a narrower agent-name grammar than the APIs enforce. The MCP trigger accepts an agent definition name or command handle, including /architect, while agent definitions can also use names such as release planner or architect.v2. Facility emits acknowledgements for those valid values, but this matcher still counts them as material issue changes, so the stale-plan failure remains.
Please make acknowledgement recognition work for every valid agent name or command handle, and add regression coverage for a slash command and a custom agent name. With that fixed, this should be ready.
shuntianyifang
force-pushed
the
codex/fix-queue-plan-freshness
branch
from
September 1, 2026 12:20
ee31bd4 to
8f03d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Closes #222
Facility could count its own queued-run acknowledgement as a new issue revision. An already approved architect plan would then appear stale before the builder started.
Testing
The full release-shaped pnpm verify runs in GitHub Actions on Ubuntu with Node.js 22. It is not reported as a Windows-local result because the upstream checkout currently has unrelated Windows-only baseline failures; no repository check or test was disabled.