feat(hitl): record decision-time review context - #234
Open
shuntianyifang wants to merge 2 commits into
Open
Conversation
shuntianyifang
force-pushed
the
codex/record-hitl-review-context
branch
from
September 1, 2026 18:03
2fb11b8 to
eaa5efa
Compare
shuntianyifang
marked this pull request as ready for review
September 1, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReviewContextV1snapshot forplan_acceptancedecisionsreview_presentedand copy it intoapproved/rejectedevents for self-contained auditability/buildercopy only that immutable publication evidenceThis follows up on the audit gap discussed in #147 and on the provenance work in #205.
Compared with the original #147 comment, this PR includes the minimum UI binding needed to prove what was actually presented. It does not add drift thresholds, override policy, or other admission policy.
Refs #147
Follow-up to #205
Queue-comment workaround
This PR does not change queued-comment behavior and does not include #223. Deployment/test projects should keep:
{ "execution_lane": { "architect": "platform", "builder": "platform", "codex-architect": "platform", "codex-builder": "platform" } }Tests should enter through GitHub /architect or /codex-architect, not the direct console or MCP proposal trigger. A deployment-test identity may also omit runs:trigger while retaining hitl:decide.
Verification
Automated verification passed:
After the follow-up fix that omits Content-Type from the bodyless review-context request, the targeted Web tests, Web typecheck, production Web build, Biome checks, and git diff --check were rerun successfully.
Live Docker Compose verification passed:
Windows-only repository limitations observed: