Skip to content

Release: Windows builds on Blacksmith while Windows signing is off - #16321

Closed
bherbruck wants to merge 1 commit into
mainfrom
ci/release-windows-blacksmith
Closed

bherbruck wants to merge 1 commit into
mainfrom
ci/release-windows-blacksmith

Conversation

@bherbruck

@bherbruck bherbruck commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

The Windows release jobs move to Blacksmith's blacksmith-8vcpu-windows-2025, the runner CI already uses for Windows. They've been the long pole of every release: 0.41.0's took 1 h 28 min to 1 h 44 min each on windows-latest, after waiting about 25 minutes for the icons job.

They only stayed on GitHub-hosted runners for SignPath. SignPath's open-source policy only signs a request when every job before it ran on a GitHub-hosted runner. With WINDOWS_SIGNING=off (#16263, now set on the repo) nothing goes to SignPath, so that constraint no longer applies. The runner follows the same switch: off builds on Blacksmith, and any other value keeps windows-latest and the SignPath steps exactly as they are.

Only runs-on changes. The other release jobs stay where they are for now. Moving them is a separate PR.

Test: dry runs (gh workflow run release.yml --ref <branch> -f draft=false). They build artifacts only: no draft, no tag, no release-branch push.

Changes a default: no

Summary by CodeRabbit

  • Chores
    • Windows releases now use a different build runner depending on whether signing is enabled.

With WINDOWS_SIGNING=off the Windows job sends nothing to SignPath, so it no
longer has to run on a GitHub-hosted runner. It runs on
blacksmith-8vcpu-windows-2025, as CI does. With signing on it stays on
windows-latest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bherbruck bherbruck added owner-approved Owner reviewed a sensitive-path change (kernel, CI, build scripts, deps); only the owner adds this approved-for-ci Reviewed: run the full PR CI (build, tests, goldens, Clippy) labels Nov 13, 2026
@github-actions github-actions Bot added the area:infra CI, tooling, repo, docs label Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

No actionable comments were generated in the recent review.

Walkthrough

The Windows release job now selects its runner based on WINDOWS_SIGNING. When the value is off, it uses blacksmith-8vcpu-windows-2025; otherwise, it uses windows-latest.

Changes: Windows Release Runner

Layer / File(s) Summary
Select Windows runner
.github/workflows/release.yml
The Windows job uses blacksmith-8vcpu-windows-2025 when WINDOWS_SIGNING is off. Otherwise, it uses windows-latest.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to ff6c1

This moves the Windows release jobs to a Blacksmith runner only while Windows signing is off. Signed releases keep using the GitHub-hosted runner. The change is confined to workflow configuration and uses a runner label the repository's CI already relies on, so merge risk is minimal.

Architecture risk: Low · up to ff6c1

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/release.yml: The Windows job no longer always uses windows-latest. It runs on the Blacksmith Windows 2025 runner when WINDOWS_SIGNING is off, and on windows-latest otherwise.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a6ee91f and ff6c13e.

Files selected for processing: 1

  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@bherbruck

Copy link
Copy Markdown
Collaborator Author

Superseded by #16323, which moves every release job to Blacksmith. The FreeBSD, Flatpak and Snap fixes from here are in it.

@bherbruck bherbruck closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Reviewed: run the full PR CI (build, tests, goldens, Clippy) area:infra CI, tooling, repo, docs owner-approved Owner reviewed a sensitive-path change (kernel, CI, build scripts, deps); only the owner adds this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant