Repository navigation
Conversation
With WINDOWS_SIGNING=off the Windows job sends nothing to SignPath, so it no longer has to run on a GitHub-hosted runner. It runs on blacksmith-8vcpu-windows-2025, as CI does. With signing on it stays on windows-latest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Superseded by #16323, which moves every release job to Blacksmith. The FreeBSD, Flatpak and Snap fixes from here are in it. |
The Windows release jobs move to Blacksmith's
blacksmith-8vcpu-windows-2025, the runner CI already uses for Windows. They've been the long pole of every release: 0.41.0's took 1 h 28 min to 1 h 44 min each onwindows-latest, after waiting about 25 minutes for the icons job.They only stayed on GitHub-hosted runners for SignPath. SignPath's open-source policy only signs a request when every job before it ran on a GitHub-hosted runner. With
WINDOWS_SIGNING=off(#16263, now set on the repo) nothing goes to SignPath, so that constraint no longer applies. The runner follows the same switch:offbuilds on Blacksmith, and any other value keepswindows-latestand the SignPath steps exactly as they are.Only
runs-onchanges. The other release jobs stay where they are for now. Moving them is a separate PR.Test: dry runs (
gh workflow run release.yml --ref <branch> -f draft=false). They build artifacts only: no draft, no tag, no release-branch push.blacksmith-8vcpu-windows-2025, from the follow-up branch that moves every job: https://github.com/tangency-labs/solidcraft/actions/runs/43490708719. Windows x64 took 39 min, x86 31 min and arm64 46 min, all green, unsigned asWINDOWS_SIGNING=offintends.Changes a default: no
Summary by CodeRabbit