Skip to content

Release builds run on Blacksmith runners, with the FreeBSD, Flatpak and Snap failures fixed - #16324

Closed
bherbruck wants to merge 2 commits into
mainfrom
ci/release-blacksmith-2
Closed

bherbruck wants to merge 2 commits into
mainfrom
ci/release-blacksmith-2

Conversation

@bherbruck

Copy link
Copy Markdown
Collaborator

Every release build job runs on Blacksmith, as CI does. This is the second try at #15227, which #15774 reverted. The three failures that caused the revert are fixed properly here, not worked around.

It stacks on #16321, which moves only the Windows job. Once that merges, this diff shrinks to the rest.

Timing. 0.41.0 took 2 h 18 min, push to release (run 43348474222). Today's nightly took about 2 h 4 min. The dry run of this branch finished its last build job 47 minutes after dispatch.

Job 0.41.0 (GitHub) This branch (Blacksmith)
Windows x64 / x86 / arm64 1 h 44 / 1 h 33 / 1 h 28, after 25 min of icons 39 / 31 / 46 min, no icons wait
FreeBSD 1 h 6 16 min
Linux x86_64 / aarch64 48 / 33 min 10 / 16 min
macOS build (each half) about 1 h 8 min
Web 29 min 20 min

What moved, and the fixes

  • FreeBSD (blacksmith-16vcpu-ubuntu-2404, which has KVM). The VM action syncs $HOME/work into the VM and then cds into $GITHUB_WORKSPACE. That only works when the checkout lives under $HOME/work, as on GitHub's runners. Blacksmith's checkout is under $HOME/_work, so the old job failed with rsync: change_dir "/home/runner/work" failed. The action now only starts the VM (sync: no). rsync copies the source in and dist/release out, so the job no longer depends on the runner's paths. The VM is sized from the runner (all but 2 CPUs and 4 GB), at about 3 GB per build job. The checkout goes in without the token (persist-credentials: false).
  • Flatpak (blacksmith-4vcpu-ubuntu-2404, -arm). sysctl kernel.apparmor_restrict_unprivileged_userns=0 failed because Blacksmith's kernel doesn't have that switch, and it doesn't block user namespaces either. It's only set where the switch exists.
  • Snap (same runners). snap install snapcraft got HTTP 408 from the Snap Store. It retries up to 5 times with backoff, here and in the release job's Snap Store upload.
  • Linux: blacksmith-16vcpu-ubuntu-2204 and -2204-arm, so the glibc 2.35 floor is unchanged. Arch: blacksmith-2vcpu-ubuntu-2404. Web: blacksmith-8vcpu-ubuntu-2404. Release job: blacksmith-2vcpu-ubuntu-2404.
  • macOS: blacksmith-12vcpu-macos-15 for the two build halves (Apple silicon; x86_64 is cross-compiled), blacksmith-6vcpu-macos-15 for join, sign and notarize. The signing steps are unchanged.
  • version and Windows: Blacksmith while WINDOWS_SIGNING=off. With signing on they go back to GitHub-hosted runners, because SignPath only signs when every job before the request ran on one. The SignPath steps are unchanged.
  • The icons job is gone. make_icons only copies committed files, and package.ps1 falls back to the same committed solidcraft.ico, so the MSI gets the same bytes. Windows no longer waits about 25 minutes for it.

New runner labels are in .github/actionlint.yaml. docs/releasing.md now describes the SignPath runner rule.

Dry run (gh workflow run release.yml --ref ci/release-blacksmith-2 -f draft=false: no draft, no tag, no release-branch push): https://github.com/tangency-labs/solidcraft/actions/runs/43490708719

Every build job is green. One job is red: macOS universal, at notarization. Apple answered HTTP 403 "A required agreement is missing or has expired". Today's nightly hit the same error on GitHub's own macos-15, so it isn't the runner, and it clears once the Apple Developer agreement is signed. Because that job failed, the release job (checksums and the dry-run artifact) was skipped and didn't run on Blacksmith here.

I'm holding this until after 0.42.0 ships, so tonight's release only takes the Windows change.

Changes a default: no

bherbruck and others added 2 commits November 13, 2026 15:52
With WINDOWS_SIGNING=off the Windows job sends nothing to SignPath, so it no
longer has to run on a GitHub-hosted runner. It runs on
blacksmith-8vcpu-windows-2025, as CI does. With signing on it stays on
windows-latest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every release job moves to Blacksmith, as CI did, with the three failures
that reverted #15227 fixed:

- FreeBSD: the VM action syncs $HOME/work and cds into $GITHUB_WORKSPACE,
  which only exists in the VM where the checkout lives under $HOME/work.
  The action now only starts the VM (sync: no); rsync copies the source in
  and dist/ out. The VM is sized from the runner.
- Flatpak: the AppArmor user-namespace sysctl is only set where it exists.
- Snap: installing snapcraft retries Snap Store timeouts (HTTP 408).

version and windows run on GitHub's runners while SignPath signs, since
SignPath only signs when every job before it ran on a GitHub-hosted
runner; with WINDOWS_SIGNING=off they run on Blacksmith too. The icons
job goes: make_icons only copies the committed icon files, and
package.ps1 falls back to the same committed solidcraft.ico.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the area:infra CI, tooling, repo, docs label Nov 13, 2026
@bherbruck bherbruck added owner-approved Owner reviewed a sensitive-path change (kernel, CI, build scripts, deps); only the owner adds this approved-for-ci Reviewed: run the full PR CI (build, tests, goldens, Clippy) labels Nov 13, 2026
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@bherbruck

Copy link
Copy Markdown
Collaborator Author

Superseded by #16323, which moves every release job to Blacksmith. The FreeBSD, Flatpak and Snap fixes from here are in it.

@bherbruck bherbruck closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Reviewed: run the full PR CI (build, tests, goldens, Clippy) area:infra CI, tooling, repo, docs owner-approved Owner reviewed a sensitive-path change (kernel, CI, build scripts, deps); only the owner adds this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant