Repository navigation
Conversation
With WINDOWS_SIGNING=off the Windows job sends nothing to SignPath, so it no longer has to run on a GitHub-hosted runner. It runs on blacksmith-8vcpu-windows-2025, as CI does. With signing on it stays on windows-latest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every release job moves to Blacksmith, as CI did, with the three failures that reverted #15227 fixed: - FreeBSD: the VM action syncs $HOME/work and cds into $GITHUB_WORKSPACE, which only exists in the VM where the checkout lives under $HOME/work. The action now only starts the VM (sync: no); rsync copies the source in and dist/ out. The VM is sized from the runner. - Flatpak: the AppArmor user-namespace sysctl is only set where it exists. - Snap: installing snapcraft retries Snap Store timeouts (HTTP 408). version and windows run on GitHub's runners while SignPath signs, since SignPath only signs when every job before it ran on a GitHub-hosted runner; with WINDOWS_SIGNING=off they run on Blacksmith too. The icons job goes: make_icons only copies the committed icon files, and package.ps1 falls back to the same committed solidcraft.ico. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Collaborator
Author
|
Superseded by #16323, which moves every release job to Blacksmith. The FreeBSD, Flatpak and Snap fixes from here are in it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every release build job runs on Blacksmith, as CI does. This is the second try at #15227, which #15774 reverted. The three failures that caused the revert are fixed properly here, not worked around.
It stacks on #16321, which moves only the Windows job. Once that merges, this diff shrinks to the rest.
Timing. 0.41.0 took 2 h 18 min, push to release (run 43348474222). Today's nightly took about 2 h 4 min. The dry run of this branch finished its last build job 47 minutes after dispatch.
What moved, and the fixes
blacksmith-16vcpu-ubuntu-2404, which has KVM). The VM action syncs$HOME/workinto the VM and thencds into$GITHUB_WORKSPACE. That only works when the checkout lives under$HOME/work, as on GitHub's runners. Blacksmith's checkout is under$HOME/_work, so the old job failed withrsync: change_dir "/home/runner/work" failed. The action now only starts the VM (sync: no). rsync copies the source in anddist/releaseout, so the job no longer depends on the runner's paths. The VM is sized from the runner (all but 2 CPUs and 4 GB), at about 3 GB per build job. The checkout goes in without the token (persist-credentials: false).blacksmith-4vcpu-ubuntu-2404,-arm).sysctl kernel.apparmor_restrict_unprivileged_userns=0failed because Blacksmith's kernel doesn't have that switch, and it doesn't block user namespaces either. It's only set where the switch exists.snap install snapcraftgot HTTP 408 from the Snap Store. It retries up to 5 times with backoff, here and in the release job's Snap Store upload.blacksmith-16vcpu-ubuntu-2204and-2204-arm, so the glibc 2.35 floor is unchanged. Arch:blacksmith-2vcpu-ubuntu-2404. Web:blacksmith-8vcpu-ubuntu-2404. Release job:blacksmith-2vcpu-ubuntu-2404.blacksmith-12vcpu-macos-15for the two build halves (Apple silicon; x86_64 is cross-compiled),blacksmith-6vcpu-macos-15for join, sign and notarize. The signing steps are unchanged.WINDOWS_SIGNING=off. With signing on they go back to GitHub-hosted runners, because SignPath only signs when every job before the request ran on one. The SignPath steps are unchanged.make_iconsonly copies committed files, andpackage.ps1falls back to the same committedsolidcraft.ico, so the MSI gets the same bytes. Windows no longer waits about 25 minutes for it.New runner labels are in
.github/actionlint.yaml. docs/releasing.md now describes the SignPath runner rule.Dry run (
gh workflow run release.yml --ref ci/release-blacksmith-2 -f draft=false: no draft, no tag, no release-branch push): https://github.com/tangency-labs/solidcraft/actions/runs/43490708719Every build job is green. One job is red: macOS universal, at notarization. Apple answered HTTP 403 "A required agreement is missing or has expired". Today's nightly hit the same error on GitHub's own
macos-15, so it isn't the runner, and it clears once the Apple Developer agreement is signed. Because that job failed, the release job (checksums and the dry-run artifact) was skipped and didn't run on Blacksmith here.I'm holding this until after 0.42.0 ships, so tonight's release only takes the Windows change.
Changes a default: no