-
Notifications
You must be signed in to change notification settings - Fork 3
Packet/july 7 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Packet/july 7 #21
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
c074d57
Add new form fields and integrate Freshdesk API for published researc…
suejinkim20 6f747d9
- migrate contact and support page to Astro format for build-time fet…
suejinkim20 6662816
Refactor form error handling and status messages for consistency acro…
suejinkim20 9900673
feat(publications): update schema and data structure for publications
suejinkim20 014d067
Enhance Button component usage with centered alignment option in expl…
suejinkim20 3f99f02
clean up code formatting and improve readability
suejinkim20 baa9d39
Merge pull request #3 from suejinkim20/feature/bdc-enabled-research-p…
suejinkim20 22341bf
enhance filter functionality and sorting logic; improve styles
suejinkim20 2f50fe5
Merge branch 'update/july-1' into feature/bdc-enabled-research-page-ui
suejinkim20 814aac5
Merge branch 'packet/july-7' into feature/form-integration
suejinkim20 04fc645
Merge branch 'packet/july-7' into feature/bdc-enabled-research-page-ui
suejinkim20 18aac79
Merge pull request #7 from suejinkim20/feature/bdc-enabled-research-p…
suejinkim20 7e8b890
Merge pull request #6 from suejinkim20/feature/form-integration
suejinkim20 a3fd7e1
Fix formatting and errors; improve code consistency
suejinkim20 de63883
implement custom object payload builder and record fetching utilities
suejinkim20 2f29361
Enhance SiteAlert component with multiple variants and styles; add se…
suejinkim20 d3e5bbf
Add banner content, currently all set to false
suejinkim20 c66a80b
Enhance filtering features and publication submission
suejinkim20 f575b49
Update Accessibility page
suejinkim20 d5994a6
Add external link handling to markdown processing
suejinkim20 91ada3d
Refactor success message in DynamicForm component to use dynamic text
suejinkim20 5a9891e
Implement "Other" option handling in form fields with dynamic text input
suejinkim20 c861a84
Add storageKey prop to SiteAlert component for better state management
suejinkim20 18974af
Add back missing props
suejinkim20 6eee526
Remove left-border styles from sitewide alert
suejinkim20 c2acfdc
Use literal key notation in buildPayload tests
suejinkim20 8072154
Remove unused getReferenceDataValues functionality
suejinkim20 b177e8d
Update publication list to use journalName on home page
suejinkim20 c39066f
Remove handling for RELATIONSHIP fields and getReferenceDataValues() …
suejinkim20 b78a2e4
Move styles from inline to scss for filter chip on PublicationsFilter…
suejinkim20 ab2f507
Move styles from inline to scss for TooltipIcon, PublicationCard
suejinkim20 dfabcb7
Add comments to clarify the purpose of the lastReviewed field in Page…
suejinkim20 54d183b
refactor CustomObjectField and CustomObjectSchema, removing unused fi…
suejinkim20 db148c3
remove RELATIONSHIP fields with build-time warning; align comments
suejinkim20 08c6736
update tests to reflect RELATIONSHIP exclusion and trimmed field types
suejinkim20 15bcd59
remove stale getReferenceDataValues references from renderCustomObjec…
suejinkim20 90ab74c
align comments with actual implementation across custom object form c…
suejinkim20 34fbd17
replace Icon.astro with Icon.tsx across components for react compatib…
suejinkim20 18c3224
remove unused EepMember.astro component
suejinkim20 45f9e1c
update Button to remove unneeded ternary and simplify class handling
suejinkim20 cc55ee3
move component-scoped styles into app directory and out of shared the…
suejinkim20 64defbc
Add Tooltip.tsx; remove Tooltip.astro and TooltipIcon components; upd…
suejinkim20 470dac9
Update event and news links match updated navigation structure
suejinkim20 2b8f88d
Update PublicationsFilter and DynamicCustomObjectForm to use client:v…
suejinkim20 645fe51
Restore containerClasses variable, remove noIcon prop, move styles in…
suejinkim20 a8aee35
add aria-label to tooltip component
suejinkim20 ea197b6
refactor styles for PublicationsCard and PublicationsFilter
suejinkim20 50f8294
refactor SiteAlert styles to rely on utility classes, except for grad…
suejinkim20 5398c54
refactor Tooltip styles to rely on utility classes; remove _tooltip.scss
suejinkim20 9aadcc5
remove getReferenceDataValues function and tests
suejinkim20 ede82a4
Revert "replace Icon.astro with Icon.tsx across components for react …
suejinkim20 4d95253
change Icon import for button back to .astro
suejinkim20 edc54e5
utilize Trussworks Icon components
suejinkim20 ba3121d
add aria-hidden attribute to Icon components for accessibility
suejinkim20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { Icon, Tooltip as TrussTooltip } from '@trussworks/react-uswds'; | ||
|
|
||
| interface Props { | ||
| text: string; | ||
| position?: 'top' | 'bottom' | 'left' | 'right'; | ||
| } | ||
|
|
||
| export default function Tooltip({ text, position = 'top' }: Props) { | ||
| return ( | ||
| <TrussTooltip | ||
| label={text} | ||
| position={position} | ||
| className="bg-transparent padding-0 cursor-pointer text-primary-dark margin-left-1 height-3 width-3" | ||
| aria-label={text} | ||
| > | ||
| <Icon.InfoOutline aria-hidden size={3} /> | ||
| </TrussTooltip> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we dropping these props?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one Button instance broken by this is on the Explore page https://github.com/stagecc/bdc-web/pull/21/changes#diff-3764fe46c68134afe78934e871ef9c68ace0e011b21a87c7f3b85cd243d561feR57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for
center, there's a USWDS utility for thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! that was a mistake.