Packet/july 7 by suejinkim20 · Pull Request #21 · stagecc/bdc-web

suejinkim20 · 2026-07-06T19:32:36Z

Deployment preview available here: https://packet-july-7.d47440bgt2n0.amplifyapp.com/

This PR addresses the following Jira items:

It also addresses Form components and backend infrastructure with the option to use both Custom Forms and Custom Objects. The Published Research Submission form uses a Custom Object.

…h submissions - Implement HoneypotField to trap bots in forms. - Create DateField, TextField, and TextareaField components for various input types. - Add DynamicForm to handle form submissions with Freshdesk integration. - Fetch form field configuration from Freshdesk at build time. - Build payload for Freshdesk API submissions, mapping fields appropriately. - Add tests for payload building and form field fetching. - Update Base layout to conditionally load reCAPTCHA script. - Modify Freshdesk handler to support new published research submission route. - Update USWDS theme package references for organizational consistency.

…ching - Integrated dynamic form fetching from Freshdesk with error handling. - enhance Freshdesk form field fetching logic - add unit tests for reCAPTCHA token retrieval

…ss components

- Changed 'location' field to 'journalName' in the publications schema. - Added optional fields: 'status', 'bdcContribution', 'researchArea', and 'researchCommunity'. - Updated publications.yaml to reflect the new schema, including new entries and fields. - Refactored news page to utilize a PublicationsFilter component and simplified publication data handling.

…ore page

…age-ui feat(publications): update schema and data structure for publications

…age-ui Feature/bdc enabled research page UI

Feature/form integration

…ssion dismiss functionality

mbwatson · 2026-07-07T15:11:09Z

i'm seeing a potential discrepancy in the CI lint check and a local check

$ npm run lint

> lint
> biome check .

#
# details omitted for space
# 

Checked 167 files in 134ms. No fixes applied.
Found 6 infos.

mbwatson

looks pretty good! i noted a couple major and a few minor fixes

mbwatson · 2026-07-07T15:15:52Z

+ *      - Research Areas → MultiSelectCheckbox
+ *      - Org Contributions → MultiSelectCheckbox
+ *      - Research Communities → MultiSelectCheckbox
+ *   Reference data options are merged into the relevant field configs before


can you say more about/fix this? i see the import of getReferenceDataValues, but i don't see any obvious merging with configs

this is leftover from when i was thinking about stitching multiple custom objects together (so a publication submission might have reference to a separate research community custom object).

this may still be an option we want to utilize but it can be removed for now, and addressed if we decide to go that route in the future.

yep that can go until we have the feature

mbwatson · 2026-07-07T15:28:01Z


 const {
  variant = 'info',
+  style = 'gradient',


above comments say style — 'border' | 'gradient'. Defaults to 'border'.

i think we can remove the 'border' styles altogether. i was mostly testing it out to see how it looked and i think that left border looks too awkward way on the end for a site-wide banner.

mbwatson · 2026-07-07T15:29:38Z

 ---

-<Tag 
-  {...targetUrl ? { href: targetUrl } : { type }} 


why are we dropping these props?

one Button instance broken by this is on the Explore page https://github.com/stagecc/bdc-web/pull/21/changes#diff-3764fe46c68134afe78934e871ef9c68ace0e011b21a87c7f3b85cd243d561feR57

for center, there's a USWDS utility for that

thank you! that was a mistake.

…in renderCustomObjectField

… and status chip on PublicationsCard

….astro

…elds

…tField

…omponents

…ility; rename class prop to className to align with react

…me files

…ate usages

…isible instead of client:load

…to .scss file

…ient colors

…compatibility; rename class prop to className to align with react" This reverts commit 34fbd17.

mbwatson

👍 good work, this was a hefty one!

mbwatson · 2026-07-07T15:42:23Z

 ---

-<Tag 
-  {...targetUrl ? { href: targetUrl } : { type }} 


one Button instance broken by this is on the Explore page https://github.com/stagecc/bdc-web/pull/21/changes#diff-3764fe46c68134afe78934e871ef9c68ace0e011b21a87c7f3b85cd243d561feR57

mbwatson · 2026-07-07T16:00:08Z

+        }}
+        aria-label="More information"
+      >
+        <svg


why not use https://designsystem.digital.gov/components/icon/ ?

mbwatson · 2026-07-07T16:07:24Z

 ---

-<Tag 
-  {...targetUrl ? { href: targetUrl } : { type }} 


for center, there's a USWDS utility for that

mbwatson · 2026-07-07T16:09:47Z

+          </a>
+        </h4>
+        <ul
+          className="usa-collection__meta margin-top-2"


margin-top-2 utility and inline margin-top CSS here

mbwatson · 2026-07-07T19:19:02Z

+ *      - Research Areas → MultiSelectCheckbox
+ *      - Org Contributions → MultiSelectCheckbox
+ *      - Research Communities → MultiSelectCheckbox
+ *   Reference data options are merged into the relevant field configs before


yep that can go until we have the feature

suejinkim20 and others added 21 commits June 18, 2026 11:05

- migrate contact and support page to Astro format for build-time fet…

6f747d9

…ching - Integrated dynamic form fetching from Freshdesk with error handling. - enhance Freshdesk form field fetching logic - add unit tests for reCAPTCHA token retrieval

Refactor form error handling and status messages for consistency acro…

6662816

…ss components

Enhance Button component usage with centered alignment option in expl…

014d067

…ore page

clean up code formatting and improve readability

3f99f02

Merge pull request #3 from suejinkim20/feature/bdc-enabled-research-p…

baa9d39

…age-ui feat(publications): update schema and data structure for publications

enhance filter functionality and sorting logic; improve styles

22341bf

Merge branch 'update/july-1' into feature/bdc-enabled-research-page-ui

2f50fe5

Merge branch 'packet/july-7' into feature/form-integration

814aac5

Merge branch 'packet/july-7' into feature/bdc-enabled-research-page-ui

04fc645

Merge pull request #7 from suejinkim20/feature/bdc-enabled-research-p…

18aac79

…age-ui Feature/bdc enabled research page UI

Merge pull request #6 from suejinkim20/feature/form-integration

7e8b890

Feature/form integration

Fix formatting and errors; improve code consistency

a3fd7e1

implement custom object payload builder and record fetching utilities

de63883

Enhance SiteAlert component with multiple variants and styles; add se…

2f29361

…ssion dismiss functionality

Add banner content, currently all set to false

d3e5bbf

Enhance filtering features and publication submission

c66a80b

Update Accessibility page

f575b49

Add external link handling to markdown processing

d5994a6

Refactor success message in DynamicForm component to use dynamic text

91ada3d

suejinkim20 requested a review from mbwatson July 7, 2026 14:32

mbwatson requested changes Jul 7, 2026

View reviewed changes

suejinkim20 added 5 commits July 7, 2026 14:52

Implement "Other" option handling in form fields with dynamic text input

5a9891e

Add storageKey prop to SiteAlert component for better state management

c861a84

Add back missing props

18974af

Remove left-border styles from sitewide alert

6eee526

Use literal key notation in buildPayload tests

c2acfdc

suejinkim20 force-pushed the packet/july-7 branch from 084fd7d to c2acfdc Compare July 7, 2026 19:29

suejinkim20 added 27 commits July 7, 2026 17:05

Update publication list to use journalName on home page

b177e8d

Remove handling for RELATIONSHIP fields and getReferenceDataValues() …

c39066f

…in renderCustomObjectField

Move styles from inline to scss for filter chip on PublicationsFilter…

b78a2e4

… and status chip on PublicationsCard

Move styles from inline to scss for TooltipIcon, PublicationCard

ab2f507

Add comments to clarify the purpose of the lastReviewed field in Page…

dfabcb7

….astro

refactor CustomObjectField and CustomObjectSchema, removing unused fi…

54d183b

…elds

remove RELATIONSHIP fields with build-time warning; align comments

db148c3

update tests to reflect RELATIONSHIP exclusion and trimmed field types

08c6736

remove stale getReferenceDataValues references from renderCustomObjec…

15bcd59

…tField

align comments with actual implementation across custom object form c…

90ab74c

…omponents

replace Icon.astro with Icon.tsx across components for react compatib…

34fbd17

…ility; rename class prop to className to align with react

remove unused EepMember.astro component

18c3224

update Button to remove unneeded ternary and simplify class handling

45f9e1c

move component-scoped styles into app directory and out of shared the…

cc55ee3

…me files

Add Tooltip.tsx; remove Tooltip.astro and TooltipIcon components; upd…

64defbc

…ate usages

Update event and news links match updated navigation structure

470dac9

Update PublicationsFilter and DynamicCustomObjectForm to use client:v…

2b8f88d

…isible instead of client:load

Restore containerClasses variable, remove noIcon prop, move styles in…

645fe51

…to .scss file

add aria-label to tooltip component

a8aee35

refactor styles for PublicationsCard and PublicationsFilter

ea197b6

refactor SiteAlert styles to rely on utility classes, except for grad…

50f8294

…ient colors

refactor Tooltip styles to rely on utility classes; remove _tooltip.scss

5398c54

remove getReferenceDataValues function and tests

9aadcc5

Revert "replace Icon.astro with Icon.tsx across components for react …

ede82a4

…compatibility; rename class prop to className to align with react" This reverts commit 34fbd17.

change Icon import for button back to .astro

4d95253

utilize Trussworks Icon components

edc54e5

add aria-hidden attribute to Icon components for accessibility

ba3121d

suejinkim20 force-pushed the packet/july-7 branch from 880a30e to ba3121d Compare July 10, 2026 21:03

mbwatson approved these changes Jul 10, 2026

View reviewed changes

mbwatson merged commit 143c616 into stagecc:main Jul 10, 2026
10 checks passed

Uh oh!

Conversation

suejinkim20 commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbwatson commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbwatson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbwatson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

suejinkim20 commented Jul 6, 2026 •

edited

Loading

mbwatson commented Jul 7, 2026 •

edited

Loading