Skip to content

fix(ios): newarch - fix codegen config to use fabric components inste… #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfazekas merged 2 commits into from
Sep 2, 2025
Merged

fix(ios): newarch - fix codegen config to use fabric components inste… #3959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a538ef7
fix(ios): newarch - fix codegen config to use fabric components inste…
mfazekas Aug 31, 2025
649be85
Update ios/RNMBX/RNMBXCircleLayerViewManager.m
mfazekas Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ios/RNMBX/RNMBXCameraViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#if !RCT_NEW_ARCH_ENABLED

#import "React/RCTBridgeModule.h"
#import <React/RCTViewManager.h>
#import <Foundation/Foundation.h>
Expand All @@ -22,3 +24,4 @@ @interface RCT_EXTERN_REMAP_MODULE(RNMBXCamera, RNMBXCameraViewManager, RCTViewM
RCT_EXPORT_VIEW_PROPERTY(stop, NSDictionary)

@end
#endif
18 changes: 10 additions & 8 deletions ios/RNMBX/RNMBXCameraViewManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import Foundation
import MapboxMaps
#if !RCT_NEW_ARCH_ENABLED
import Foundation
import MapboxMaps

@objc(RNMBXCameraViewManager)
class RNMBXCameraViewManager : RCTViewManager {
@objc(RNMBXCameraViewManager)
class RNMBXCameraViewManager: RCTViewManager {
@objc
override static func requiresMainQueueSetup() -> Bool {
return false
return false
}

override func view() -> UIView! {
return RNMBXCamera()
return RNMBXCamera()
}
}
}
#endif
2 changes: 1 addition & 1 deletion ios/RNMBX/RNMBXCircleLayerComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ - (instancetype)initWithFrame:(CGRect)frame
if (self = [super initWithFrame:frame]) {
static const auto defaultProps = std::make_shared<const RNMBXCircleLayerProps>();
_props = defaultProps;
[self prepareView];
[self prepareView];
}

return self;
Expand Down
2 changes: 2 additions & 0 deletions ios/RNMBX/RNMBXCircleLayerViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if !RCT_NEW_ARCH_ENABLED
#import <React/RCTBridgeModule.h>
#import <React/RCTViewManager.h>

Expand All @@ -10,3 +11,4 @@ @interface RCT_EXTERN_REMAP_MODULE(RNMBXCircleLayer, RNMBXCircleLayerViewManager
#include "CommonLayerProperties.H"

@end
#endif
2 changes: 2 additions & 0 deletions ios/RNMBX/RNMBXCircleLayerViewManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if !RCT_NEW_ARCH_ENABLED
@objc(RNMBXCircleLayerViewManager)
class RNMBXCircleLayerViewManager: RCTViewManager {
@objc
Expand All @@ -11,3 +12,4 @@ class RNMBXCircleLayerViewManager: RCTViewManager {
return layer
}
}
#endif
2 changes: 2 additions & 0 deletions ios/RNMBX/RNMBXMapViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if !RCT_NEW_ARCH_ENABLED
#import <React/RCTBridgeModule.h>
#import <React/RCTViewManager.h>

Expand Down Expand Up @@ -41,3 +42,4 @@ @interface RCT_EXTERN_REMAP_MODULE(RNMBXMapView, RNMBXMapViewManager, RCTViewMan
RCT_EXPORT_VIEW_PROPERTY(mapViewImpl, NSString)

@end
#endif
Loading