Skip to content

fix(ios): newarch - fix codegen config to use fabric components inste… - #3959

Merged
mfazekas merged 2 commits into
mainfrom
fix-new-arch-codegen-config
Sep 2, 2025
Merged

mfazekas merged 2 commits into
mainfrom
fix-new-arch-codegen-config

Conversation

@mfazekas

Copy link
Copy Markdown
Contributor

…ad of legacy in new arch

See:
https://github.com/facebook/react-native-website/pull/4388/files#diff-7fbb6ff2e58f8bd50d2763e551c63e1816adb6d593f40d489785b575b0e82718R76
software-mansion/react-native-gesture-handler@7826f50
software-mansion/react-native-svg#2572

Description

Fixes #

Added your feature that allows ...

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Component to reproduce the issue you're fixing

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the iOS codegen configuration for React Native's new architecture by replacing legacy component references with Fabric components and auto-generating the required iOS components configuration in package.json.

  • Auto-generates iOS components configuration from NativeComponent spec files
  • Wraps legacy ViewManager classes with #if !RCT_NEW_ARCH_ENABLED preprocessor directives
  • Reformats Swift code for improved readability and consistency

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/autogenerate.mjs Adds call to generate iOS components configuration
scripts/autogenHelpers/generateIOSComponents.mjs New utility to scan specs and generate iOS components config
package.json Adds auto-generated iOS components and componentsProvider configuration
ios/RNMBX/*.swift Wraps legacy ViewManager classes with new arch conditionals and code formatting
ios/RNMBX/*.m Wraps legacy ViewManager classes with new arch conditionals

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread ios/RNMBX/RNMBXCircleLayerViewManager.m Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This branch was previously deployed

1 inactive deployment
default — 649be852 Deployed Sep 2, 2025 by mfazekas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants