Repository navigation
fix(ios): newarch - fix codegen config to use fabric components inste… - #3959
Merged
Merged
Conversation
mfazekas
force-pushed
the
fix-new-arch-codegen-config
branch
from
August 31, 2025 07:19
d005d47 to
ccc11a3
Compare
…ad of legacy in new arch
mfazekas
force-pushed
the
fix-new-arch-codegen-config
branch
from
September 1, 2025 19:22
ccc11a3 to
a538ef7
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the iOS codegen configuration for React Native's new architecture by replacing legacy component references with Fabric components and auto-generating the required iOS components configuration in package.json.
- Auto-generates iOS components configuration from NativeComponent spec files
- Wraps legacy ViewManager classes with
#if !RCT_NEW_ARCH_ENABLEDpreprocessor directives - Reformats Swift code for improved readability and consistency
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/autogenerate.mjs | Adds call to generate iOS components configuration |
| scripts/autogenHelpers/generateIOSComponents.mjs | New utility to scan specs and generate iOS components config |
| package.json | Adds auto-generated iOS components and componentsProvider configuration |
| ios/RNMBX/*.swift | Wraps legacy ViewManager classes with new arch conditionals and code formatting |
| ios/RNMBX/*.m | Wraps legacy ViewManager classes with new arch conditionals |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ad of legacy in new arch
See:
https://github.com/facebook/react-native-website/pull/4388/files#diff-7fbb6ff2e58f8bd50d2763e551c63e1816adb6d593f40d489785b575b0e82718R76
software-mansion/react-native-gesture-handler@7826f50
software-mansion/react-native-svg#2572
Description
Fixes #
Added
your featurethat allows ...Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing