Skip to content

chore: Replicate simplecov changes to config gems #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwear merged 1 commit into from
Sep 14, 2026
+4 −0
Merged

chore: Replicate simplecov changes to config gems #2342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ eval_gemfile File.expand_path('../Gemfile', __dir__)
gemspec

group :test, :development do
gem 'dotenv', '3.2.0'

@simi simi Sep 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in already evaled root Gemfile 🤔.

opentelemetry-ruby/Gemfile

Line 9 in ab29f85

gem 'dotenv', '~> 3.2.0'

@thompson-tomo thompson-tomo Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct but I would rather have it as it is to be consistent with all the other gems & we can tackle further optimisations in a future pr.

@simi simi Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that emit warning (or failure) in bundler?

@thompson-tomo thompson-tomo Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither, it is just an info

2026-09-08T14:53:01.2947238Z Your Gemfile lists the gem dotenv (~> 3.2.0) more than once.
2026-09-08T14:53:01.2948161Z You should probably keep only one of them.
2026-09-08T14:53:01.2948774Z Remove any duplicate entries and specify the gem only once.
2026-09-08T14:53:01.2949671Z While it's not a problem now, it could cause errors if you change the version of one of them later.

We have renovate which will update both of them hence we would avoid the error scenario

@kaylareopelle kaylareopelle Sep 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear @simi's concern, but agree with @thompson-tomo that we should address it in a different PR. @thompson-tomo would you mind opening an issue to address this?

@thompson-tomo thompson-tomo Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done #2391

gem 'minitest', '6.0.6'
gem 'simplecov', '1.0.0'
gem 'yard', '0.9.45'
Expand Down
3 changes: 3 additions & 0 deletions config/test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
# Copyright The OpenTelemetry Authors
# SPDX-License-Identifier: Apache-2.0

require 'dotenv'
Dotenv.load(File.expand_path('.env', __dir__))

require 'simplecov'
SimpleCov.start

Expand Down
Loading