chore: Replicate simplecov changes to config gems - #2342
Conversation
thompson-tomo
changed the title
18c6722 to
29c7d55
Compare
thompson-tomo
changed the title
thompson-tomo
changed the title
| gemspec | ||
|
|
||
| group :test, :development do | ||
| gem 'dotenv', '3.2.0' |
There was a problem hiding this comment.
This is in already evaled root Gemfile 🤔.
Line 9 in ab29f85
There was a problem hiding this comment.
You are correct but I would rather have it as it is to be consistent with all the other gems & we can tackle further optimisations in a future pr.
There was a problem hiding this comment.
Doesn't that emit warning (or failure) in bundler?
There was a problem hiding this comment.
Neither, it is just an info
2026-09-08T14:53:01.2947238Z Your Gemfile lists the gem dotenv (~> 3.2.0) more than once.
2026-09-08T14:53:01.2948161Z You should probably keep only one of them.
2026-09-08T14:53:01.2948774Z Remove any duplicate entries and specify the gem only once.
2026-09-08T14:53:01.2949671Z While it's not a problem now, it could cause errors if you change the version of one of them later.
We have renovate which will update both of them hence we would avoid the error scenario
There was a problem hiding this comment.
I hear @simi's concern, but agree with @thompson-tomo that we should address it in a different PR. @thompson-tomo would you mind opening an issue to address this?
4 participants
This replicates the changes in #2117 to the config gem as it was missed