Skip to content

Skip libjade tests until new upstream is resolved - #2714

Open
owaldron wants to merge 1 commit into
open-quantum-safe:mainfrom
owaldron:ci/libjade-upstream-moved
Open

owaldron wants to merge 1 commit into
open-quantum-safe:mainfrom
owaldron:ci/libjade-upstream-moved

Conversation

@owaldron

Copy link
Copy Markdown
Contributor

As explained in #2697, the libjade job in the exteded/weekly CI is failing because upstream libjade moved their repository from formosa-crypto/libjade to formosa-crypto/formosa-libjade, which no longer has the branch nor commit that copy_from_libjade used to pull from. It also seems that upstream doesn't have any commit on their main branch which can be substituted cleanly.

Fixing this may therefore be more involved, so this PR skips the failing libjadecheck CI job until a stable fix is decided and merged.


  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged. Also, make sure to update the list of algorithms in the continuous benchmarking files: .github/workflows/kem-bench.yml and sig-bench.yml)

Generative AI Disclosure: Claude Code (Claude Opus 5.5) was used to search the upstream repo for equivalent commits, and couldn't find any.

formosa-crypto/libjade moved to formosa-crypto/formosa-libjade and its
history was removed, so the pinned `release/2023.05-2` commit can no
longer be fetched. Make `copy_from_upstream.py libjade` exit with an
explanation, record the situation in `copy_from_libjade.yml`, disable
the `libjadecheck` job, and point the CONFIGURE.md link at the new
repository. The imported code is unchanged.

Assisted-by: Claude:claude-opus-5.5
Signed-off-by: Owen Waldron <owen.waldron@uwaterloo.ca>
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 79.964%. remained the same — owaldron:ci/libjade-upstream-moved into open-quantum-safe:main

@owaldron
owaldron marked this pull request as ready for review November 18, 2026 18:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants