Skip to content

Fix weekly ct-test memsan job errors - #2716

Open
owaldron wants to merge 1 commit into
open-quantum-safe:mainfrom
owaldron:ci/memsan-seccomp-unconfined
Open

owaldron wants to merge 1 commit into
open-quantum-safe:mainfrom
owaldron:ci/memsan-seccomp-unconfined

Conversation

@owaldron

@owaldron owaldron commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

MSan jobs were failing over the last couple weekly CT tests (2026-11-14, 2026-11-07), and Claude was able to diagnose the issue: in runners with vm.mmap_rnd_bits=32, MSan needs to sometimes re-exec itself with personality(ADDR_NO_RANDOMIZE), which Docker's default seccomp profile blocks.

The fix is to disable seccomp for the memsan runner's containers, so that this re-exec can succeed without being blocked. A run of the ct-tests on my fork succeeds after this flag is added: https://github.com/owaldron/liboqs/actions/runs/44388550257

Along with #2714, this should get weekly CI green again.


  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged. Also, make sure to update the list of algorithms in the continuous benchmarking files: .github/workflows/kem-bench.yml and sig-bench.yml)

Generative AI Disclosure: Claude Code (Claude Opus 5.5) was used to help diagnose the issue, discuss fixes, and aid with understanding.

MSan runners were failing in the weekly CT tests, and Claude was able
to diagnose the issue: in runners with vm.mmap_rnd_bits=32, MSan needs
to sometimes re-exec itself with `personality(ADDR_NO_RANDOMIZE)`, which
Docker's default seccomp profile blocks.

The fix is to disable seccomp for the MSan container, so that this
re-exec can succeed without being blocked.

Assisted-by: Claude:claude-opus-5.5
Signed-off-by: Owen Waldron <owen.waldron@uwaterloo.ca>
@owaldron

Copy link
Copy Markdown
Contributor Author

@pablo-gf please take a look if you can, since I don't know enough about the ct-tests to know if this affects their behaviour

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 79.946% (-0.003%) from 79.949% — owaldron:ci/memsan-seccomp-unconfined into open-quantum-safe:main

@owaldron
owaldron marked this pull request as ready for review November 18, 2026 21:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants