Skip to content

fix: replace bare except with except Exception in gmaps/utils helpers #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrueFurina wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: replace bare except with except Exception in gmaps/utils helpers #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ghunt/helpers/gmaps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def calculate_probable_location(geolocator: Nominatim, reviews_and_photos: List[
try:
location = geolocator.reverse(f"{avg[0]}, {avg[1]}", timeout=10).raw["address"]
break
except:
except Exception:
pass
location = sanitize_location(location)
locs[nb]["avg"] = location
Expand Down
2 changes: 1 addition & 1 deletion ghunt/helpers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def is_headers_syntax_good(headers: Dict[str, str]) -> bool:
try:
httpx.Headers(headers)
return True
except:
except Exception:
return False

async def get_url_image_flathash(as_client: httpx.AsyncClient, image_url: str) -> str:
Expand Down