fix: replace bare except with except Exception in gmaps/utils helpers - #606
Open
TrueFurina wants to merge 1 commit into
Open
fix: replace bare except with except Exception in gmaps/utils helpers#606TrueFurina wants to merge 1 commit into
TrueFurina wants to merge 1 commit into
Conversation
Author
|
Hi maintainers — just checking in on this PR. It fixes bare |
|
I haven't received any paycheck yet, please inform the head quarter.
…On Wed, Aug 26, 2026, 9:59 AM Dream ***@***.***> wrote:
*TrueFurina* left a comment (mxrch/GHunt#606)
<#606 (comment)>
Hi maintainers — just checking in on this PR. It fixes bare except:
clauses (KeyboardInterrupt/SystemExit were being intercepted first). Happy
to adjust anything to help get this merged. Thanks!
—
Reply to this email directly, view it on GitHub
<#606?email_source=notifications&email_token=ASKOUZA62F3D5B222OFUUMD5L2DGBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNBSGE3TGNJSHE22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-5421735295>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKOUZF2VHAB3W4R2OLERR35L2DGBAVCNFSNUABFKJSXA33TNF2G64TZHMZTAMBVHEZDSMBXHNEXG43VMU5TKMJTG44DAMJTGE22C5QC>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bare
except:clauses swallow everything, includingKeyboardInterrupt/SystemExit:ghunt/helpers/gmaps.py(geolocation reverse lookup retry loop) — intendedto skip a failed reverse-geocode lookup
ghunt/helpers/utils.py(is_headers_syntax_good) — intended to returnFalse on invalid headers
Replace both with
except Exception:— same intended behavior, butunexpected exceptions (e.g.
NameError) now propagate instead of beinghidden.
Verification
python -m py_compile ghunt/helpers/gmaps.py ghunt/helpers/utils.py→ OKgrep -rn "except:" ghunt/→ 0 remaining bare handlersFiles changed
ghunt/helpers/gmaps.py(1 line)ghunt/helpers/utils.py(1 line)