Skip to content

Remove Xapian bindings from message ID lookup - #21

Open
larskotthoff with Copilot wants to merge 4 commits into
mainfrom
copilot/alternative-get-ids-implementation
Open

larskotthoff with Copilot wants to merge 4 commits into
mainfrom
copilot/alternative-get-ids-implementation

Conversation

Copilot AI commented Nov 2, 2026 •

Copy link
Copy Markdown

Xapian bindings can’t be installed with Python 3.15 on macOS, blocking installation of notmuch-sync. Replace the Xapian-dependent get_ids implementation so the application can work without those bindings.

  • Message ID lookup: Query all messages through notmuch2, including excluded messages, and skip ghosts.
    with notmuch2.Database(path=prefix, mode=notmuch2.Database.MODE.READ_ONLY) as db:
        for msg in db.messages("*", omit_excluded=notmuch2.Database.EXCLUDE.FALSE):
            if not msg.ghost and msg.messageid:
                message_ids.append(msg.messageid)
  • Dependencies and docs: Remove xapian-bindings from project and requirements dependencies; update installation guidance.
  • CI: Remove explicit Xapian packages from workflow setup.

Copilot AI and others added 2 commits November 2, 2026 11:21
Co-authored-by: larskotthoff <579233+larskotthoff@users.noreply.github.com>
Co-authored-by: larskotthoff <579233+larskotthoff@users.noreply.github.com>
Copilot AI changed the title [WIP] Provide alternative implementation of get_ids without xapian Remove Xapian bindings from message ID lookup Nov 2, 2026
Copilot AI requested a review from larskotthoff November 2, 2026 11:25
@larskotthoff

Copy link
Copy Markdown
Owner

@copilot Tests are failing.

Co-authored-by: larskotthoff <579233+larskotthoff@users.noreply.github.com>

Copilot AI commented Nov 2, 2026

Copy link
Copy Markdown
Author

@copilot Tests are failing.

I checked the CI logs: mypy failed because err_remote was passed to select() before its None check. I moved the check first; fix is in 81073de. The unit tests, critical flake8 checks, and targeted mypy check now pass.

@larskotthoff
larskotthoff marked this pull request as ready for review November 2, 2026 11:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot install with python3.15 on macos (because of xapian-bindings)

2 participants