Skip to content

Rename pr-approved-issue.yml to pull-request-validation.yml - #15

Merged
jeffcarp merged 2 commits into
keras-team:mainfrom
jeffcarp:rename-pull-request-validation
Sep 28, 2026
Merged

jeffcarp merged 2 commits into
keras-team:mainfrom
jeffcarp:rename-pull-request-validation

Conversation

@jeffcarp

@jeffcarp jeffcarp commented Sep 28, 2026 •

Copy link
Copy Markdown
Member
  • Renames .github/workflows/pr-approved-issue.yml to .github/workflows/pull-request-validation.yml per review discussion on keras-team/keras#23768.
  • Defaults the checkout ref to ${{ inputs.ref || job.workflow_sha }} so callers only need to pin the SHA once in uses: keras-team/shared-workflows/.github/workflows/pull-request-validation.yml@<sha> without duplicating with: ref: '<sha>' (per @SamanehSaadat's comment on keras#23768).

Re: #9

@laxmareddyp

Copy link
Copy Markdown
Contributor

Should be updated here once it is merged.

https://github.com/keras-team/keras-hub/blob/master/.github/workflows/pr-approved-issue.yml

@jeffcarp

Copy link
Copy Markdown
Member Author

SG will do @laxmareddyp. This won't break the keras-hub script in prod because it's tied to the SHA. If the PR looks good would you mind approving?

@hertschuh hertschuh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffcarp
jeffcarp merged commit 5759d01 into keras-team:main Sep 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants