Add pull-request-validation.yml workflow - #23768
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23768 +/- ##
==========================================
- Coverage 86.95% 85.17% -1.78%
==========================================
Files 492 492
Lines 71781 71964 +183
Branches 11838 11874 +36
==========================================
- Hits 62416 61295 -1121
- Misses 6243 7659 +1416
+ Partials 3122 3010 -112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hertschuh
left a comment
There was a problem hiding this comment.
LGTM.
But I'm confused why it's called pr-approved-issue? I would not know to look there if I needed to change it.
How about one of these (or something else)?
|
May be these can consider:
|
I like that one. It's still generic enough. |
SG! Sent keras-team/shared-workflows#15
That would be great, created keras-team/shared-workflows#16 for this. |
Summary of Changes
.github/workflows/pull-request-validation.yml:5759d017529ab86921f5908358dd9bf9ee86a14e) to convert external contributor PRs to draft if they do not link an approved issue assigned to the PR author.job.workflow_shaby default inshared-workflowsso only a single SHA needs to be pinned.keras-team/keras#23601):.github/PULL_REQUEST_TEMPLATE.mdto link todocs/pr_policy.mdinstead of thekeras#23601issue URL, preventing GitHub from creating across-referencedtimeline event on the RFC issue for every single PR opened.Re: keras-team/shared-workflows#9