Skip to content

Add pull-request-validation.yml workflow - #23768

Merged
jeffcarp merged 3 commits into
keras-team:masterfrom
jeffcarp:add-pr-approved-issue
Sep 28, 2026
Merged

jeffcarp merged 3 commits into
keras-team:masterfrom
jeffcarp:add-pr-approved-issue

Conversation

@jeffcarp

@jeffcarp jeffcarp commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary of Changes

  • Enable .github/workflows/pull-request-validation.yml:
    • Calls the centralized reusable workflow from keras-team/shared-workflows#13 and keras-team/shared-workflows#15 (5759d017529ab86921f5908358dd9bf9ee86a14e) to convert external contributor PRs to draft if they do not link an approved issue assigned to the PR author.
    • Uses job.workflow_sha by default in shared-workflows so only a single SHA needs to be pinned.
  • Stop every PR from referencing the original RFC issue (keras-team/keras#23601):
    • Updates .github/PULL_REQUEST_TEMPLATE.md to link to docs/pr_policy.md instead of the keras#23601 issue URL, preventing GitHub from creating a cross-referenced timeline event on the RFC issue for every single PR opened.

Re: keras-team/shared-workflows#9

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PR contribution policy link in the pull request template to point to the shared workflows documentation. I have no feedback to provide on this change.

@codecov-commenter

codecov-commenter commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.17%. Comparing base (58db6d6) to head (49d00e2).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #23768      +/-   ##
==========================================
- Coverage   86.95%   85.17%   -1.78%     
==========================================
  Files         492      492              
  Lines       71781    71964     +183     
  Branches    11838    11874      +36     
==========================================
- Hits        62416    61295    -1121     
- Misses       6243     7659    +1416     
+ Partials     3122     3010     -112     
Flag Coverage Δ
keras 84.98% <ø> (-1.79%) ⬇️
keras-cpu 84.25% <ø> (-1.87%) ⬇️
keras-gpu 70.79% <ø> (+<0.01%) ⬆️
keras-jax 59.33% <ø> (-1.84%) ⬇️
keras-numpy 54.03% <ø> (-0.22%) ⬇️
keras-openvino 60.53% <ø> (-0.17%) ⬇️
keras-tensorflow 60.91% <ø> (-1.86%) ⬇️
keras-torch 60.57% <ø> (-1.85%) ⬇️
keras-tpu 58.17% <ø> (-0.02%) ⬇️
keras.applications ?
keras.applications-jax ?
keras.applications-numpy ?
keras.applications-openvino ?
keras.applications-tensorflow ?
keras.applications-torch ?
keras.wrappers ?
keras.wrappers-jax ?
keras.wrappers-numpy ?
keras.wrappers-openvino ?
keras.wrappers-tensorflow ?
keras.wrappers-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hertschuh hertschuh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But I'm confused why it's called pr-approved-issue? I would not know to look there if I needed to change it.

@google-ml-butler google-ml-butler Bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Sep 25, 2026
@jeffcarp

Copy link
Copy Markdown
Member Author

LGTM.

But I'm confused why it's called pr-approved-issue? I would not know to look there if I needed to change it.

How about one of these (or something else)?

  • pull-request-validation.yml
  • check-pr-attaches-valid-issue.yml

@SamanehSaadat SamanehSaadat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread .github/workflows/pull-request-validation.yml
Comment thread .github/workflows/pr-approved-issue.yml Outdated
@laxmareddyp

laxmareddyp commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

LGTM.
But I'm confused why it's called pr-approved-issue? I would not know to look there if I needed to change it.

How about one of these (or something else)?

  • pull-request-validation.yml
  • check-pr-attaches-valid-issue.yml

May be these can consider:

  • pr-require-assigned-issue.yml
  • pr-linked-issue-check.yml
  • enforce-issue-assignment.yml

@hertschuh

Copy link
Copy Markdown
Collaborator
  • pull-request-validation.yml

I like that one. It's still generic enough.

@jeffcarp

Copy link
Copy Markdown
Member Author
  • pull-request-validation.yml

I like that one. It's still generic enough.

SG! Sent keras-team/shared-workflows#15

On a related note, our Dependabot configuration is currently duplicated across all our repositories—could we centralize it into shared-workflows to manage it across the entire Keras ecosystem from a single place?

That would be great, created keras-team/shared-workflows#16 for this.

@google-ml-butler google-ml-butler Bot removed the ready to pull Ready to be merged into the codebase label Sep 28, 2026
@jeffcarp jeffcarp changed the title Add PR approved issue check workflow Add pull-request-validation.yml workflow Sep 28, 2026

@laxmareddyp laxmareddyp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks..!

@google-ml-butler google-ml-butler Bot added the ready to pull Ready to be merged into the codebase label Sep 28, 2026
@jeffcarp
jeffcarp merged commit 8a4533e into keras-team:master Sep 28, 2026
17 checks passed
@google-ml-butler google-ml-butler Bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants