Repository navigation
transpile: Refactor and merge convert_condition and match_bool - #2018
Merged
Merged
Conversation
Rua
force-pushed
the
convert_condition-refactor
branch
from
September 21, 2026 13:15
fa29a94 to
51cf76e
Compare
Rua
marked this pull request as draft
September 21, 2026 13:15
Rua
force-pushed
the
convert_condition-refactor
branch
2 times, most recently
from
September 21, 2026 13:58
2671d93 to
a8751c9
Compare
Rua
force-pushed
the
convert_condition-refactor
branch
3 times, most recently
from
October 8, 2026 11:10
d99cfb3 to
9cb73f0
Compare
Rua
marked this pull request as ready for review
October 8, 2026 11:10
ahomescu
reviewed
Oct 21, 2026
ahomescu
left a comment
ahomescu
left a comment
Contributor
There was a problem hiding this comment.
I only had time for a quick look, will do a deeper review tomorrow.
Rua
force-pushed
the
convert_condition-refactor
branch
2 times, most recently
from
October 21, 2026 09:27
ccb93c9 to
281f52e
Compare
ahomescu
reviewed
Oct 21, 2026
ahomescu
reviewed
Oct 21, 2026
ahomescu
requested changes
Oct 21, 2026
Contributor
|
Are the snapshots identical? |
Rua
force-pushed
the
convert_condition-refactor
branch
from
October 22, 2026 10:11
281f52e to
c337a9f
Compare
Contributor
Author
|
They should be, this is supposed to be a refactor and not a fix/improvement to the output. |
Rua
force-pushed
the
convert_condition-refactor
branch
from
October 22, 2026 10:28
c337a9f to
9bf91c8
Compare
…r and return types
Rua
force-pushed
the
convert_condition-refactor
branch
from
October 22, 2026 15:09
9bf91c8 to
34bcc18
Compare
ahomescu
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used()flag #1975This introduces a new enum
IdOrExprthat functions can take, to allow them to accept either a yet-to-be-translated CCExprIdor an already-translated RustBox<Expr>. That in turn allows some functions to perform both roles.