Repository navigation
Conversation
Rua
force-pushed
the
make_cast-no-withstmts
branch
10 times, most recently
from
September 16, 2026 10:04
87e2433 to
c596896
Compare
Rua
force-pushed
the
make_cast-no-withstmts
branch
from
September 16, 2026 14:21
c596896 to
654c3e0
Compare
ahomescu
reviewed
Sep 17, 2026
| } | ||
|
|
||
| CastKind::NullToPointer => { | ||
| return Ok(WithStmts::new_val(self.null_ptr(ty.ctype)?)); |
Contributor
There was a problem hiding this comment.
Should we use target_ty.ctype here instead?
Rua
force-pushed
the
make_cast-no-withstmts
branch
5 times, most recently
from
September 24, 2026 08:46
ad93fdb to
f3643f6
Compare
Rua
changed the title
WithStmts for make_cast and other cast functionsWithStmts parameter for most functions
Rua
force-pushed
the
make_cast-no-withstmts
branch
from
September 26, 2026 16:38
3fb8095 to
fcf1a73
Compare
Rua
force-pushed
the
make_cast-no-withstmts
branch
2 times, most recently
from
October 8, 2026 11:12
89aadc0 to
b3392eb
Compare
Rua
force-pushed
the
make_cast-no-withstmts
branch
from
October 22, 2026 19:26
b3392eb to
bd2ce51
Compare
Rua
force-pushed
the
make_cast-no-withstmts
branch
2 times, most recently
from
October 23, 2026 10:11
01168be to
ec0416c
Compare
Rua
force-pushed
the
make_cast-no-withstmts
branch
from
October 23, 2026 10:15
ec0416c to
7377e8e
Compare
Contributor
Author
|
I'm closing this because now that #2018 landed, it's better to combine these changes with a larger refactor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only thing here that actually required a
WithStmtsspecifically was an assert for theNullToPointercase. That case was throwing out the existingWithStmtsand replacing it with a new one, resulting in a double translation.NullToPointeris never returned byCastKind::from_types, and so that path is only ever hit when being called fromconvert_cast. So I just movedNullToPointerthere instead.