[TMP] IBX-12046: Adapted templated router to DefaultRouter decorator - #236
Open
ViniTou wants to merge 4 commits into
Open
[TMP] IBX-12046: Adapted templated router to DefaultRouter decorator#236ViniTou wants to merge 4 commits into
ViniTou wants to merge 4 commits into
Conversation
Ibexa\Bundle\Core\Routing\DefaultRouter is now a decorator in ibexa/core and no longer extends the FrameworkBundle Router, so the templated router service wraps an inner hautelook.router.template child instead of inheriting its definition.
ViniTou
changed the title
ViniTou
force-pushed
the
ibx-12046-default-router-decorator
branch
from
September 9, 2026 11:34
651c07f to
7b542ae
Compare
…ed_router The REST-owned RFC 6570 router instance was registered under core's class name, which misrepresents what it is and captures autowiring of Ibexa\Bundle\Core\Routing\DefaultRouter for every bundle. The old id stays as a deprecated alias for one release; both in-repo consumers now inject ibexa.rest.templated_router explicitly.
ViniTou
force-pushed
the
ibx-12046-default-router-decorator
branch
2 times, most recently
from
September 10, 2026 10:50
32cda33 to
7ec0134
Compare
mikadamczyk
approved these changes
Sep 10, 2026
| gh-client-secret: ${{ secrets.AUTOMATION_CLIENT_SECRET }} | ||
| satis-network-key: ${{ secrets.SATIS_NETWORK_KEY }} | ||
| satis-network-token: ${{ secrets.SATIS_NETWORK_TOKEN }} | ||
| composer-options: "--prefer-dist --no-progress --no-suggest" |
Contributor
There was a problem hiding this comment.
Could we drop this line for consistency? --no-suggest is also a no-op since Composer 2.0
Contributor
Author
There was a problem hiding this comment.
This commit should be marked as [TMP] as well, this is just to wire up CI on both ends.
…ation job Temporary, revert together with the dependencies.json pin before merging: the ibexa/gh-workflows composer-install action applies dependencies.json to the root composer.json before installing, which is the only way the core#822 branch reaches the unit and integration suites while core#822 is unmerged. CI workflow changes are owned by the workflow template, not by this PR.
ViniTou
force-pushed
the
ibx-12046-default-router-decorator
branch
from
September 10, 2026 12:50
7ec0134 to
7caba4a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Companion to ibexa/core#822, which turns
Ibexa\Bundle\Core\Routing\DefaultRouterinto a decorator ofrouter.defaultinstead of a subclass of the@finalFrameworkBundle Router. The REST templated URI router (RFC 6570 hrefs in the root resource and value object visitors) was declared as aDefaultRouterservice withparent: hautelook.router.template, which hands the FrameworkBundle Router constructor arguments to the new decorator and fails to instantiate.The templated router is now registered as
ibexa.rest.templated_router(wrapping a newibexa.rest.templated_router.innerchild ofhautelook.router.template);ExpressionRouterRootResourceBuilderandValueObjectVisitor::setTemplateRouter()inject it explicitly. The old idIbexa\Bundle\Core\Routing\DefaultRouterstays as a deprecated alias for one release: it named a REST-owned, differently configured instance after core's class and captured autowiring of that type for every bundle. Test kernels in cart, checkout and segmentation still call$container->set(DefaultRouter::class, …); withHautelookTemplatedUriBundleregistered in all three that override is not load-bearing (verified here by booting the REST integration kernel against the core#822 branch), but they can move to the new id at leisure. Behaviour is unchanged: as before, no SiteAccess is injected into this router and REST routes are configured as non-SiteAccess-aware, so generated hrefs are identical.Merge order: ibexa/core#822 first, this PR second. Until then CI resolves core from
dependencies.json([TMP] Pin Core dependencycommit), and a second[TMP]commit temporarily switches the unit/integration job to the sharedibexa/gh-workflows/actions/composer-installaction so that file is applied to the root composer.json (asprepare_project_edition.shalready does for the functional job). Revert both[TMP]commits before merging — CI workflow changes belong to the workflow template, not to this PR. This PR alone (against the current core) breaks container compilation because the currentDefaultRouterconstructor is the FrameworkBundle Router one; core#822 alone breaks REST because of the oldparent:definition. Neither should be released without the other.For QA:
REST root resource (
/api/ibexa/v2/) and any response with templated hrefs ({contentId}style URIs) render as before;cache:warmupanddebug:container Ibexa\Bundle\Core\Routing\DefaultRoutersucceed with core#822 installed.Documentation:
N/A