IBX-12046: Removed Symfony 8 deprecated code usage - #237
Open
ViniTou wants to merge 1 commit into
Open
Conversation
Replaced Request::get() calls with explicit bag access (query) in GetBasedQueryContentTypeQueryBuilder so the repo emits no direct Symfony deprecations on 7.4 ahead of the Symfony 8 upgrade.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Aligns this repo with Symfony 7.4's contracts so no Symfony 8-removed API is used, ahead of the future Symfony 8 upgrade. Scope was limited to the one category the static/live scan found here:
Request::get()→ explicit$request->query->get()access inGetBasedQueryContentTypeQueryBuilder(4 call sites:limit,offset,filter,sort), since these are GET query-string parameters for a GET-based query builder.No voters, constraints,
UserInterfaceimplementations,OptionsResolvernested-defaults usage, Twigapp.request.get()calls (repo has no Twig templates),symfony/templatingusage, or PHP 8.4 implicit-nullable parameters were found in this repo. No BC handling was needed sinceRequest::get()had no return-type/semantic change, just a call-site rewrite.For QA:
Exercise the REST content-type query endpoints that pass
limit,offset,filter, andsortquery-string parameters — behavior is unchanged, only the internal request-bag access changed.Documentation:
N/A — internal (
@internal) class, no public API change.