ci: Make test-runs in CI more strict, to emphasize need of improvements

e2e/README.md

@@ -11,6 +11,7 @@
   - [Set necessary Environment-variables](#set-necessary-environment-variables)
 - [Running tests](#running-tests)
   - [Using the command-line](#using-the-command-line)
+  - [Flaky tests](#flaky-tests)
   - [Using the VS Code-extension](#using-the-vs-code-extension)
 - [Fixtures](#fixtures)
   - [What are fixtures in Playwright?](#what-are-fixtures-in-playwright)

e2e/playwright.config.ts

@@ -12,7 +12,7 @@ export default defineConfig({
   fullyParallel: false,
   // eslint-disable-next-line n/no-process-env -- This environment variable `CI` is NOT used in the 121-service, thus not managed via the env.ts file.
   forbidOnly: !!process.env.CI, // Fail the build on CI if you accidentally left test.only in the source code.
-  retries: 1,
+  retries: 0,
   reporter: [['list']],
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
   workers: 1,
@@ -21,7 +21,7 @@ export default defineConfig({
   use: {
     // eslint-disable-next-line n/no-process-env -- This environment variable `BASE_URL` is NOT used in the 121-service, thus not managed via the env.ts file.
     baseURL: process.env.BASE_URL ?? 'http://localhost:8088',
-    video: 'on-first-retry',
+    video: 'retain-on-failure',
     screenshot: 'only-on-failure',
     headless: true,
     acceptDownloads: true,
@@ -41,7 +41,7 @@ export default defineConfig({
     viewport: null,
     ignoreHTTPSErrors: true,
     bypassCSP: false,
-    trace: 'on-first-retry',
+    trace: 'retain-on-failure',
   },
   projects: [
     {

services/121-service/jest.integration.config.js

@@ -1,6 +1,5 @@
 /** @type {import('ts-jest').JestConfigWithTsJest} */
 module.exports = {
-  preset: 'ts-jest',
   rootDir: '.',
   testMatch: ['<rootDir>/test/**/*.test.ts'],
   setupFilesAfterEnv: ['jest-extended/all'],
@@ -13,15 +12,17 @@ module.exports = {
   moduleFileExtensions: ['js', 'ts'],
   transform: {
     '^.+\\.ts?$': ['ts-jest', { tsconfig: '<rootDir>/test/tsconfig.json' }],
-    'node_modules/(@t3-oss|uuid|openid-client|oauth4webapi|jose|sanitize-html|htmlparser2|entities|domhandler|domutils|domelementtype|dom-serializer)/.+[.]js$': [
-      'ts-jest',
-      { useESM: true },
-    ],
+    'node_modules/(@t3-oss|uuid|openid-client|oauth4webapi|jose|sanitize-html|htmlparser2|entities|domhandler|domutils|domelementtype|dom-serializer)/.+[.]js$':
+      ['ts-jest', { useESM: true }],
+    '^.+\\.tsx?$': ['ts-jest', {}],
   },
   transformIgnorePatterns: [
     'node_modules/(?!@t3-oss|uuid|openid-client|oauth4webapi|jose|sanitize-html|htmlparser2|entities|domhandler|domutils|domelementtype|dom-serializer)',
   ],
   testTimeout: 30_000,
+  detectOpenHandles: true,
+  errorOnDeprecated: true,
+  logHeapUsage: true,
   randomize: true,
   verbose: true,
   reporters: ['default', ['github-actions', { silent: false }], 'summary'],

services/121-service/jest.unit.config.js

@@ -1,6 +1,5 @@
 /** @type {import('ts-jest').JestConfigWithTsJest} */
 module.exports = {
-  preset: 'ts-jest',
   rootDir: '.',
   testMatch: ['<rootDir>/**/*.spec.ts'],
   setupFilesAfterEnv: [
@@ -14,14 +13,16 @@ module.exports = {
     '^@121-service/(.*)$': '<rootDir>/$1',
   },
   transform: {
-    'node_modules/(@t3-oss|uuid|openid-client|oauth4webapi|jose|sanitize-html|htmlparser2|entities|domhandler|domutils|domelementtype|dom-serializer)/.+[.]js$': [
-      'ts-jest',
-      { useESM: true },
-    ],
+    'node_modules/(@t3-oss|uuid|openid-client|oauth4webapi|jose|sanitize-html|htmlparser2|entities|domhandler|domutils|domelementtype|dom-serializer)/.+[.]js$':
+      ['ts-jest', { useESM: true }],
+    '^.+\\.tsx?$': ['ts-jest', {}],
   },
   transformIgnorePatterns: [
     'node_modules/(?!@t3-oss|uuid|openid-client|oauth4webapi|jose|sanitize-html|htmlparser2|entities|domhandler|domutils|domelementtype|dom-serializer)',
   ],
+  detectOpenHandles: true,
+  errorOnDeprecated: true,
+  logHeapUsage: true,
   randomize: true,
   verbose: true,
   reporters: [

services/121-service/package.json

@@ -24,11 +24,11 @@
     "test:unit:all": "jest --runInBand --config=jest.unit.config.js",
     "test:unit:watch": "npm run test:unit:all -- --watchAll",
     "test:unit:coverage": "npm run test:unit:all -- --coverage --coverageDirectory=coverage/unit",
-    "test:integration:local": "node --env-file-if-exists=../.env --expose-gc node_modules/.bin/jest --config=jest.integration.config.js --runInBand --detectOpenHandles --logHeapUsage",
-    "test:integration:base": "node --expose-gc node_modules/.bin/jest --config=jest.integration.config.js --runInBand --detectOpenHandles --logHeapUsage",
+    "test:integration:local": "node --env-file-if-exists=../.env --expose-gc node_modules/.bin/jest --config=jest.integration.config.js --runInBand",
+    "test:integration:base": "node --expose-gc node_modules/.bin/jest --config=jest.integration.config.js --runInBand",
     "test:integration:all": "npm run test:integration:base -- --testPathIgnorePatterns=retry-failed-jobs-on-startup-during-queue-processing.test.ts",
     "test:integration:only-restart-service": "npm run test:integration:base -- retry-failed-jobs-on-startup-during-queue-processing.test.ts",
-    "test:integration:debug": "node --inspect-brk=0.0.0.0:9231 --expose-gc node_modules/.bin/jest --config=jest.integration.config.js --runInBand --detectOpenHandles --logHeapUsage",
+    "test:integration:debug": "node --inspect-brk=0.0.0.0:9231 --expose-gc node_modules/.bin/jest --config=jest.integration.config.js --runInBand",
     "test:integration:watch": "npm run test:integration:all -- --watchAll",
     "coverage:report:unit": "echo 'This is generated with the test:unit:coverage script.' && exit 1",
     "coverage:report:integration": "nyc report --report-dir coverage/integration --reporter=lcov --reporter=text",