Skip to content

ci: Make test-runs in CI more strict, to emphasize need of improvements - #8826

Open
elwinschmitz wants to merge 6 commits into
mainfrom
elwin/fix-ci-config
Open

elwinschmitz wants to merge 6 commits into
mainfrom
elwin/fix-ci-config

Conversation

@elwinschmitz

@elwinschmitz elwinschmitz commented Sep 10, 2026

Copy link
Copy Markdown
Member

AB#44451

Describe your changes

Checklist before requesting a code review

  • I have performed a self-review of my code
  • I have addressed all Copilot comments
  • The changes do not touch the UI/UX
  • Improving the tests is the goal
  • I have made sure that all automated checks pass before requesting a review
  • I have updated all documentation where necessary
  • I have checked the list of integrations with the 121 API for changed endpoints
  • I do not need any deviation from our PR guidelines

Portal preview-deployment

This PR does not have any preview deployments yet.

Copilot AI lite review requested due to automatic review settings September 10, 2026 10:33
@elwinschmitz elwinschmitz added the chore Something that does not affect the end user label Sep 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed changes have no unresolved blocking issues.

Pull request overview

This PR makes CI test runs stricter and improves failure diagnostics for Jest and Playwright.

Changes:

  • Centralizes strict Jest diagnostics and transforms.
  • Disables Playwright retries while retaining failure artifacts.
  • Documents flaky-test guidance in the E2E README.
File summaries
File Summary
services/121-service/package.json Moves Jest diagnostics into configuration files.
services/121-service/jest.unit.config.js Adds strict diagnostics and explicit TypeScript transforms.
services/121-service/jest.integration.config.js Adds strict diagnostics and explicit TypeScript transforms.
e2e/README.md Links the flaky-tests section in the contents.
e2e/playwright.config.ts Disables retries and retains failure artifacts.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@elwinschmitz
elwinschmitz marked this pull request as draft September 11, 2026 11:10
@elwinschmitz
elwinschmitz marked this pull request as ready for review September 14, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Something that does not affect the end user

Development

Successfully merging this pull request may close these issues.

2 participants