[3/5] Make SDK evolution evidence fail closed - #53
Merged
Conversation
ebarti
force-pushed
the
agent/sdk-evolution-evidence-integrity
branch
from
July 28, 2026 17:56
754ed04 to
7bd2725
Compare
ebarti
added a commit
that referenced
this pull request
Jul 28, 2026
## Summary - map the `openai-codex-cli-bin` distribution to its real `codex_cli_bin` import module - use that module consistently for current and isolated API snapshots - require metadata, module import, `bundled_codex_path()`, and an existing regular file before the binary probe passes - preserve the `binary-distribution` probe identity for every in-process and embedded failure path - keep success evidence stable without persisting temporary executable paths - serialize binary-probe failures with bounded exception context while redacting everything from the first absolute POSIX, drive, UNC, or URL path start ## Stack - Depends on #53 - This is layer 4 of 5 in the SDK evolution demo reliability stack ## Review notes Two correctness passes covered wrong-module snapshots, metadata/import/helper/conversion/file-check failures, invalid helper returns, regular-file semantics, embedded probe labels, cross-platform path forms, diagnostic bounds, and path-bearing messages with spaces. No actionable findings remain. ## Validation - `PYTHONPATH=. .venv/bin/python -m pytest -q` — 477 passed, 8 skipped - SDK evolution test file — 114 passed - Codex CLI focused selection — 23 passed - real installed locked Codex wheel snapshot/probe — passed - `.venv/bin/ruff check .` - `.venv/bin/mypy` - `git diff --check` Security-diff scans were intentionally not part of this phase review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail > incomplete > changed > passfrom raw probes, diffs, full probe pairing, and trusted expectationsbehavior_summary.json, include it in the current-state manifest, and surface snapshot/behavior errors and reasons in the Markdown reportStack
Review notes
The layer received a two-pass correctness review. Review findings covered drifted no-update baselines, contradictory cached summaries, malformed nested details, failure precedence, partial probe sets, empty self-declared expectation scope, and real breaking-payload coverage; all were repaired and re-reviewed with no remaining actionable findings.
Validation
PYTHONPATH=. .venv/bin/python -m pytest -q— 449 passed, 12 skipped.venv/bin/ruff check ..venv/bin/mypyuv lock --checkgit diff --checkSecurity-diff scans were intentionally not part of this phase review.