Skip to content

[4/5] Inspect bundled Codex CLI correctly - #54

Merged
ebarti merged 1 commit into
mainfrom
agent/sdk-evolution-cli-bin-snapshots
Jul 28, 2026
Merged

[4/5] Inspect bundled Codex CLI correctly#54
ebarti merged 1 commit into
mainfrom
agent/sdk-evolution-cli-bin-snapshots

Conversation

@ebarti

@ebarti ebarti commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • map the openai-codex-cli-bin distribution to its real codex_cli_bin import module
  • use that module consistently for current and isolated API snapshots
  • require metadata, module import, bundled_codex_path(), and an existing regular file before the binary probe passes
  • preserve the binary-distribution probe identity for every in-process and embedded failure path
  • keep success evidence stable without persisting temporary executable paths
  • serialize binary-probe failures with bounded exception context while redacting everything from the first absolute POSIX, drive, UNC, or URL path start

Stack

Review notes

Two correctness passes covered wrong-module snapshots, metadata/import/helper/conversion/file-check failures, invalid helper returns, regular-file semantics, embedded probe labels, cross-platform path forms, diagnostic bounds, and path-bearing messages with spaces. No actionable findings remain.

Validation

  • PYTHONPATH=. .venv/bin/python -m pytest -q — 477 passed, 8 skipped
  • SDK evolution test file — 114 passed
  • Codex CLI focused selection — 23 passed
  • real installed locked Codex wheel snapshot/probe — passed
  • .venv/bin/ruff check .
  • .venv/bin/mypy
  • git diff --check

Security-diff scans were intentionally not part of this phase review.

@ebarti
ebarti marked this pull request as ready for review July 28, 2026 16:49
@ebarti
ebarti force-pushed the agent/sdk-evolution-evidence-integrity branch from 754ed04 to 7bd2725 Compare July 28, 2026 17:56
Base automatically changed from agent/sdk-evolution-evidence-integrity to main July 28, 2026 17:57
@ebarti
ebarti force-pushed the agent/sdk-evolution-cli-bin-snapshots branch from ccaa476 to 6b0af81 Compare July 28, 2026 17:58
@ebarti
ebarti merged commit 34eb4a6 into main Jul 28, 2026
11 checks passed
@ebarti
ebarti deleted the agent/sdk-evolution-cli-bin-snapshots branch July 28, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant