fix(desktop): use augmented PATH for readiness probes#1613
Merged
Conversation
Areson
force-pushed
the
Areson/fix-codex-readiness-path
branch
2 times, most recently
from
517e9f9 to
a2a90be
Compare
Co-authored-by: Ian Oberst <ioberst@squareup.com> Signed-off-by: Ian Oberst <ioberst@squareup.com> Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
Areson
force-pushed
the
Areson/fix-codex-readiness-path
branch
from
a2a90be to
ac9b17d
Compare
matt2e
added a commit
that referenced
this pull request
Jul 10, 2026
Desktop Core CI fails with "readiness.rs: 1549 lines (limit 1546)" — a breakage inherited from main, not from this branch (which only touched the Justfile). Two PRs raced: #1686 grew readiness.rs and bumped its override to exactly 1546 with zero headroom, then #1613 landed +3 net lines (mod cli_probe + the multi-line augmented-PATH probe call) without touching the override. Each PR was green against its own base; their merge on main exceeds the limit, so main has been red since 94ec2c2. Bump the override to the merged total (1549) with a comment in the file's established style. Verified with the full `pnpm check` gate that failed in CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
wpfleger96
added a commit
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Packaged desktop launches can have a sparse GUI PATH. Readiness probes resolved the Codex/Claude binary but then ran it without the augmented PATH used for agent startup, so npm shims with
/usr/bin/env nodecould fail before checking login state.What
/usr/bin/env nodeshimscodex loginand remove an unused runtime re-export that blocked targeted clippyRisk Assessment
Low — scoped to desktop managed-agent readiness probes and setup nudge copy. Probe execution still uses the resolved absolute binary path and only augments PATH for child process interpreter lookup.
References
./bin/just desktop-tauri-fmt-checkpnpm --dir desktop check:file-sizes./bin/just desktop-tauri-testcheck-push-org,rust-tests,desktop-test,desktop-tauri-test,mobile-test./bin/just desktop-tauri-clippycurrently fails on broader existing Tauri warnings outside this PR; not expanded here.Generated with Codex