chore(desktop): remove dead archive-migration and keyring load_readonly helpers#1701
Merged
Conversation
…ly helpers These four items have zero callers on main and warn on every cargo build: migration_applied, mark_migration_applied (archive/store.rs), load_readonly on KeyStore trait + impls (storage.rs), and SecretStore::load_readonly (secret_store.rs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migration_appliedandmark_migration_appliedfromarchive/store.rs— zero callers on main, warn on everycargo build.load_readonlyfrom theKeyStoretrait, itsSecretStoreimpl, and its test-fake impl instorage.rs.SecretStore::load_readonlyfromsecret_store.rs— sole caller was the trait impl above.readiness.rssize cap 1546 → 1549 incheck-file-sizes.mjs— fix(desktop): use augmented PATH for readiness probes #1613 grew the file past the cap and has had main's Desktop Core red since; this PR carries the sanctioned bump.All four items are dead code that produce
unusedwarnings.load_all_readonly(the live sibling) is untouched.