Repository navigation
Fix window controls when horizontal tab bar is hidden #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Firefox keeps a titlebar-control copy in the nav bar and normally enables it | ||
| // only when native vertical tabs set `tabs-hidden`. Lepton hides the horizontal | ||
| // tab bar with CSS, so opt into that copy directly. | ||
| #nav-bar > .titlebar-buttonbox-container { | ||
| display: flex !important; | ||
| } | ||
|
|
||
| // Match the drag space at the start of the nav bar on the inner side of | ||
| // right-aligned window controls. Firefox normally exposes this spacer only | ||
| // when its native tab strip is hidden. | ||
| @include WindowControl_Right { | ||
| :root[sizemode="normal"] | ||
| #toolbar-menubar[autohide][inactive] | ||
| ~ #nav-bar | ||
| > .titlebar-spacer[type="post-tabs"] { | ||
| display: flex !important; | ||
| } | ||
| } | ||
|
|
||
| // Lepton's existing hidden-tabbar rules expose the menubar copy, so suppress it | ||
| // while the nav-bar copy is in use. | ||
| #toolbar-menubar[inactive] > .titlebar-buttonbox-container { | ||
| display: none !important; | ||
| } | ||
|
|
||
| // A permanently visible menubar owns the controls, so hide the nav-bar copy | ||
| // just as Firefox does for native vertical tabs. | ||
| :root:not([chromehidden~="menubar"], [inFullscreen]) | ||
| #toolbar-menubar:not([autohide], [collapsed]) | ||
| ~ #nav-bar | ||
| > .titlebar-buttonbox-container { | ||
| display: none !important; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like using a different option might cause problems due to the size mode.
I will review it over the weekend, make corrections, and merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional, to match the behavior when the pre-spacer also appears only when the browser window is not maximized - which, if I remember correctly, was Lepton's behavior a several versions back.
Admittedly, I tested it only on my Windows configuration with right-side window controls, as left-sided variations are out of scope of my personal interest.