Repository navigation
Fix window controls when horizontal tab bar is hidden - #1187
Merged
Merged
Conversation
black7375
reviewed
Sep 3, 2026
Comment on lines
+11
to
+12
| @include WindowControl_Right { | ||
| :root[sizemode="normal"] |
Owner
There was a problem hiding this comment.
It seems like using a different option might cause problems due to the size mode.
I will review it over the weekend, make corrections, and merge it.
Contributor
Author
There was a problem hiding this comment.
This was intentional, to match the behavior when the pre-spacer also appears only when the browser window is not maximized - which, if I remember correctly, was Lepton's behavior a several versions back.
Admittedly, I tested it only on my Windows configuration with right-side window controls, as left-sided variations are out of scope of my personal interest.
hdk5
force-pushed
the
fix-menubar-window-control
branch
from
September 15, 2026 15:09
fae8394 to
fd557fe
Compare
hdk5
force-pushed
the
fix-menubar-window-control
branch
from
September 15, 2026 15:20
fd557fe to
45cef89
Compare
black7375
approved these changes
Oct 5, 2026
Owner
|
A bit late, but thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Firefox now provides window controls and drag spacers in the navigation toolbar for configurations where the horizontal tab strip is hidden. Lepton previously continued using the menubar/tabbar control layout and reserving a fixed window-control gap, which caused:
PR Type
Add:Add feature or enhanced.Fix:Bug fix or change default values.Clean:Refactoring.Doc:Update docs.Related Issue
#1145