Harden CKTAP certificate validation and add production-root checks - #72
Merged
Conversation
Require certificate validation to enforce the production Coinkite factory root so a fake TAPSIGNER is reported as counterfeit. Reject malformed or empty certificate data as a validation error.
praveenperera
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This hardens rust-cktap certificate validation. It does not make certificate checking automatic. Applications must call the check before setup, import, signing, or other operations that depend on card authenticity.
Cove had a separate integration defect: it created and used a TAPSIGNER without calling the certificate check. That call-site fix belongs in Cove.
Verification
All GitHub Actions build, test, formatting, and Clippy checks pass.