Preserve card nonce after invalid signature - #73
Merged
Conversation
Store the response nonce before parsing the certificate check signature so later authenticated commands use the current card nonce. Add a transport-level test for malformed signatures.
praveenperera
force-pushed
the
more-hardening
branch
from
August 10, 2026 20:04
062ebfd to
1e1d0bc
Compare
praveenperera
marked this pull request as ready for review
August 10, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A successful check command changes the nonce on the card. If signature parsing
fails before the library stores the returned nonce, the card object keeps the
old value. Later authenticated commands can then fail.
This is a follow-up to #72.
Validation
cargo fmt --all --checkcargo test -p rust-cktapcargo clippy --all-features --all-targets -- -D warnings