Skip to content

feat(Core/Common): add new helpers for time utility - #10207

Merged
Winfidonarleyan merged 9 commits into
azerothcore:masterfrom
Winfidonarleyan:chrono
Jan 19, 2022
Merged

feat(Core/Common): add new helpers for time utility#10207
Winfidonarleyan merged 9 commits into
azerothcore:masterfrom
Winfidonarleyan:chrono

Conversation

@Winfidonarleyan

@Winfidonarleyan Winfidonarleyan commented Jan 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Changes Proposed:

  • Move time unility to separated files Timer.h and Timer.cpp
  • Add new shorthand typedef std::chrono::duration (Days, Weeks, Year, Month)
  • Add new helpers for convert duration from std::chrono to std::string

Testing:

  • In game

Issues:

Source:

Modules dependence:

@Yehonal Yehonal added CORE Related to the core file-cpp Used to trigger the matrix build Script Refers to C++ Scripts for the Core labels Jan 16, 2022
@Winfidonarleyan Winfidonarleyan mentioned this pull request Jan 16, 2022
Merged
4 of 5 tasks
@Winfidonarleyan Winfidonarleyan added the run-build Used to trigger the windows/mac/docker and matrix builds label Jan 16, 2022
@Winfidonarleyan
Winfidonarleyan marked this pull request as draft January 17, 2022 00:01
@Winfidonarleyan Winfidonarleyan mentioned this pull request Jan 17, 2022
Merged
@Winfidonarleyan
Winfidonarleyan marked this pull request as ready for review January 17, 2022 03:24
@Winfidonarleyan
Winfidonarleyan marked this pull request as draft January 17, 2022 05:33
@Winfidonarleyan
Winfidonarleyan marked this pull request as ready for review January 18, 2022 05:22
@Winfidonarleyan
Winfidonarleyan merged commit 259b913 into azerothcore:master Jan 19, 2022
@Winfidonarleyan
Winfidonarleyan deleted the chrono branch January 19, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kitzunu Kitzunu Kitzunu approved these changes

Assignees

No one assigned

Labels

CORE Related to the core file-cpp Used to trigger the matrix build run-build Used to trigger the windows/mac/docker and matrix builds Script Refers to C++ Scripts for the Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Winfidonarleyan @Kitzunu @Yehonal